Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/modules/desktop_capture/window_capturer_x11.cc

Issue 2787263003: Delete all log messages depending on system_wrappers. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/window_capturer_x11.cc
diff --git a/webrtc/modules/desktop_capture/window_capturer_x11.cc b/webrtc/modules/desktop_capture/window_capturer_x11.cc
index 7468b3d7377f7dc6470b54409ec3e7f60eded153..778506523a034e3ec63c45293c9ad957fa730ee9 100644
--- a/webrtc/modules/desktop_capture/window_capturer_x11.cc
+++ b/webrtc/modules/desktop_capture/window_capturer_x11.cc
@@ -25,7 +25,6 @@
#include "webrtc/modules/desktop_capture/x11/shared_x_display.h"
#include "webrtc/modules/desktop_capture/x11/x_error_trap.h"
#include "webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.h"
-#include "webrtc/system_wrappers/include/logging.h"
namespace webrtc {
@@ -141,7 +140,6 @@ WindowCapturerLinux::WindowCapturerLinux(const DesktopCaptureOptions& options)
(major_version > 0 || minor_version >= 2)) {
has_composite_extension_ = true;
} else {
- LOG(LS_INFO) << "Xcomposite extension not available or too old.";
}
x_display_->AddEventHandler(ConfigureNotify, this);
@@ -165,8 +163,6 @@ bool WindowCapturerLinux::GetSourceList(SourceList* sources) {
int status = XQueryTree(display(), root_window, &root_window, &parent,
&children, &num_children);
if (status == 0) {
- LOG(LS_ERROR) << "Failed to query for child windows for screen "
- << screen;
continue;
}
@@ -224,7 +220,6 @@ bool WindowCapturerLinux::FocusOnSelectedSource() {
int status = XQueryTree(
display(), selected_window_, &root, &parent, &children, &num_children);
if (status == 0) {
- LOG(LS_ERROR) << "Failed to query for the root window.";
return false;
}
@@ -270,7 +265,6 @@ void WindowCapturerLinux::Start(Callback* callback) {
void WindowCapturerLinux::CaptureFrame() {
if (!x_server_pixel_buffer_.IsWindowValid()) {
- LOG(LS_INFO) << "The window is no longer valid.";
callback_->OnCaptureResult(Result::ERROR_PERMANENT, nullptr);
return;
}
@@ -281,7 +275,6 @@ void WindowCapturerLinux::CaptureFrame() {
// Without the Xcomposite extension we capture when the whole window is
// visible on screen and not covered by any other window. This is not
// something we want so instead, just bail out.
- LOG(LS_INFO) << "No Xcomposite extension detected.";
callback_->OnCaptureResult(Result::ERROR_PERMANENT, nullptr);
return;
}
@@ -308,7 +301,6 @@ bool WindowCapturerLinux::HandleXEvent(const XEvent& event) {
if (!DesktopSize(xce.width, xce.height).equals(
x_server_pixel_buffer_.window_size())) {
if (!x_server_pixel_buffer_.Init(display(), selected_window_)) {
- LOG(LS_ERROR) << "Failed to initialize pixel buffer after resizing.";
}
return true;
}
@@ -338,8 +330,6 @@ bool WindowCapturerLinux::HandleXEvent(const XEvent& event) {
unsigned int num_children;
if (!XQueryTree(display(), window, &root, &parent, &children,
&num_children)) {
- LOG(LS_ERROR) << "Failed to query for child windows although window"
- << "does not have a valid WM_STATE.";
return 0;
}
::Window app_window = 0;
@@ -403,8 +393,6 @@ bool WindowCapturerLinux::GetWindowTitle(::Window window, std::string* title) {
&cnt);
if (status >= Success && cnt && *list) {
if (cnt > 1) {
- LOG(LS_INFO) << "Window has " << cnt
- << " text properties, only using the first one.";
}
*title = *list;
result = true;
« no previous file with comments | « webrtc/modules/desktop_capture/window_capturer_win.cc ('k') | webrtc/modules/desktop_capture/x11/shared_x_display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698