Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc

Issue 2785713002: Allow RtpPacket::SetPayloadSize to increase payload size (Closed)
Patch Set: Tweaked comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/modules/rtp_rtcp/source/rtp_packet_received.h" 10 #include "webrtc/modules/rtp_rtcp/source/rtp_packet_received.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 TEST(RtpPacketTest, SetReservedExtensionsAfterPayload) { 119 TEST(RtpPacketTest, SetReservedExtensionsAfterPayload) {
120 const size_t kPayloadSize = 4; 120 const size_t kPayloadSize = 4;
121 RtpPacketToSend::ExtensionManager extensions; 121 RtpPacketToSend::ExtensionManager extensions;
122 extensions.Register(kRtpExtensionTransmissionTimeOffset, 122 extensions.Register(kRtpExtensionTransmissionTimeOffset,
123 kTransmissionOffsetExtensionId); 123 kTransmissionOffsetExtensionId);
124 extensions.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId); 124 extensions.Register(kRtpExtensionAudioLevel, kAudioLevelExtensionId);
125 RtpPacketToSend packet(&extensions); 125 RtpPacketToSend packet(&extensions);
126 126
127 EXPECT_TRUE(packet.ReserveExtension<TransmissionOffset>()); 127 EXPECT_TRUE(packet.ReserveExtension<TransmissionOffset>());
128 packet.AllocatePayload(kPayloadSize); 128 packet.SetPayloadSize(kPayloadSize);
129 // Can't set extension after payload. 129 // Can't set extension after payload.
130 EXPECT_FALSE(packet.SetExtension<AudioLevel>(kVoiceActive, kAudioLevel)); 130 EXPECT_FALSE(packet.SetExtension<AudioLevel>(kVoiceActive, kAudioLevel));
131 // Unless reserved. 131 // Unless reserved.
132 EXPECT_TRUE(packet.SetExtension<TransmissionOffset>(kTimeOffset)); 132 EXPECT_TRUE(packet.SetExtension<TransmissionOffset>(kTimeOffset));
133 } 133 }
134 134
135 TEST(RtpPacketTest, CreatePurePadding) { 135 TEST(RtpPacketTest, CreatePurePadding) {
136 const size_t kPaddingSize = kMaxPaddingSize - 1; 136 const size_t kPaddingSize = kMaxPaddingSize - 1;
137 RtpPacketToSend packet(nullptr, 12 + kPaddingSize); 137 RtpPacketToSend packet(nullptr, 12 + kPaddingSize);
138 packet.SetPayloadType(kPayloadType); 138 packet.SetPayloadType(kPayloadType);
139 packet.SetSequenceNumber(kSeqNum); 139 packet.SetSequenceNumber(kSeqNum);
140 packet.SetTimestamp(kTimestamp); 140 packet.SetTimestamp(kTimestamp);
141 packet.SetSsrc(kSsrc); 141 packet.SetSsrc(kSsrc);
142 Random random(0x123456789); 142 Random random(0x123456789);
143 143
144 EXPECT_LT(packet.size(), packet.capacity()); 144 EXPECT_LT(packet.size(), packet.capacity());
145 EXPECT_FALSE(packet.SetPadding(kPaddingSize + 1, &random)); 145 EXPECT_FALSE(packet.SetPadding(kPaddingSize + 1, &random));
146 EXPECT_TRUE(packet.SetPadding(kPaddingSize, &random)); 146 EXPECT_TRUE(packet.SetPadding(kPaddingSize, &random));
147 EXPECT_EQ(packet.size(), packet.capacity()); 147 EXPECT_EQ(packet.size(), packet.capacity());
148 } 148 }
149 149
150 TEST(RtpPacketTest, CreateUnalignedPadding) { 150 TEST(RtpPacketTest, CreateUnalignedPadding) {
151 const size_t kPayloadSize = 3; // Make padding start at unaligned address. 151 const size_t kPayloadSize = 3; // Make padding start at unaligned address.
152 RtpPacketToSend packet(nullptr, 12 + kPayloadSize + kMaxPaddingSize); 152 RtpPacketToSend packet(nullptr, 12 + kPayloadSize + kMaxPaddingSize);
153 packet.SetPayloadType(kPayloadType); 153 packet.SetPayloadType(kPayloadType);
154 packet.SetSequenceNumber(kSeqNum); 154 packet.SetSequenceNumber(kSeqNum);
155 packet.SetTimestamp(kTimestamp); 155 packet.SetTimestamp(kTimestamp);
156 packet.SetSsrc(kSsrc); 156 packet.SetSsrc(kSsrc);
157 packet.AllocatePayload(kPayloadSize); 157 packet.SetPayloadSize(kPayloadSize);
158 Random r(0x123456789); 158 Random r(0x123456789);
159 159
160 EXPECT_LT(packet.size(), packet.capacity()); 160 EXPECT_LT(packet.size(), packet.capacity());
161 EXPECT_TRUE(packet.SetPadding(kMaxPaddingSize, &r)); 161 EXPECT_TRUE(packet.SetPadding(kMaxPaddingSize, &r));
162 EXPECT_EQ(packet.size(), packet.capacity()); 162 EXPECT_EQ(packet.size(), packet.capacity());
163 } 163 }
164 164
165 TEST(RtpPacketTest, ParseMinimum) { 165 TEST(RtpPacketTest, ParseMinimum) {
166 RtpPacketReceived packet; 166 RtpPacketReceived packet;
167 EXPECT_TRUE(packet.Parse(kMinimumPacket, sizeof(kMinimumPacket))); 167 EXPECT_TRUE(packet.Parse(kMinimumPacket, sizeof(kMinimumPacket)));
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 int32_t time_offset; 294 int32_t time_offset;
295 EXPECT_FALSE(packet.GetExtension<TransmissionOffset>(&time_offset)); 295 EXPECT_FALSE(packet.GetExtension<TransmissionOffset>(&time_offset));
296 packet.IdentifyExtensions(extensions); 296 packet.IdentifyExtensions(extensions);
297 EXPECT_TRUE(packet.GetExtension<TransmissionOffset>(&time_offset)); 297 EXPECT_TRUE(packet.GetExtension<TransmissionOffset>(&time_offset));
298 EXPECT_EQ(kTimeOffset, time_offset); 298 EXPECT_EQ(kTimeOffset, time_offset);
299 EXPECT_EQ(0u, packet.payload_size()); 299 EXPECT_EQ(0u, packet.payload_size());
300 EXPECT_EQ(0u, packet.padding_size()); 300 EXPECT_EQ(0u, packet.padding_size());
301 } 301 }
302 302
303 } // namespace webrtc 303 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698