Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2784243003: iOS/MacOS:Refactor metal rendering by extracting common implementation (Closed)
Patch Set: Fix build linkage Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 89de28cb38dd520366874576216c456fa4d7f3ef..72385cd32c099eddbe69828eac8ed2ab67f487f9 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -50,12 +50,14 @@ if (is_ios || is_mac) {
"objc/Framework/Headers/WebRTC/RTCSSLAdapter.h",
"objc/Framework/Headers/WebRTC/RTCTracing.h",
]
+
deps = [
"../base:rtc_base",
]
configs += [ "..:common_objc" ]
public_configs = [ ":rtc_sdk_common_objc_config" ]
+
if (is_ios) {
sources += [
"objc/Framework/Classes/RTCCameraPreviewView.m",
@@ -65,24 +67,38 @@ if (is_ios || is_mac) {
"objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
"objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
]
- if (current_cpu == "arm64") {
+ }
+
+ if (is_mac || (is_ios && current_cpu == "arm64")) {
+ sources += [
+ "objc/Framework/Classes/Metal/RTCMTLI420Renderer.h",
+ "objc/Framework/Classes/Metal/RTCMTLI420Renderer.mm",
+ "objc/Framework/Classes/Metal/RTCMTLRenderer+Private.h",
+ "objc/Framework/Classes/Metal/RTCMTLRenderer.h",
+ "objc/Framework/Classes/Metal/RTCMTLRenderer.mm",
+ ]
+ deps += [ "../api:video_frame_api" ]
+
+ if (is_ios) {
sources += [
"objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h",
"objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm",
"objc/Framework/Classes/Metal/RTCMTLVideoView.m",
]
- deps += [ "../api:video_frame_api" ]
}
-
- libs = [ "AVFoundation.framework" ]
- if (current_cpu == "arm64") {
- libs += [
- "CoreVideo.framework",
- "Metal.framework",
- "MetalKit.framework",
- ]
+ if (is_mac) {
+ sources += [ "objc/Framework/Classes/Metal/RTCMTLNSVideoView.m" ]
}
}
+
+ libs = [ "AVFoundation.framework" ]
+ if (is_mac || (is_ios && current_cpu == "arm64")) {
+ libs += [
+ "CoreVideo.framework",
+ "Metal.framework",
+ "MetalKit.framework",
+ ]
+ }
if (!build_with_chromium) {
sources += [
"objc/Framework/Classes/RTCFileLogger.mm",
@@ -224,9 +240,6 @@ if (is_ios || is_mac) {
if (is_mac) {
sources += [
- "objc/Framework/Classes/Metal/RTCMTLI420Renderer.h",
- "objc/Framework/Classes/Metal/RTCMTLI420Renderer.mm",
- "objc/Framework/Classes/Metal/RTCMTLNSVideoView.m",
"objc/Framework/Classes/RTCNSGLVideoView.m",
"objc/Framework/Headers/WebRTC/RTCMTLNSVideoView.h",
"objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h",

Powered by Google App Engine
This is Rietveld 408576698