Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 2784023002: Major AEC3 render pipeline changes (Closed)
Patch Set: Disabled one more DEATH test that caused issues due to bug on bots Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index 13f6edfb8b5aebf8faf03362b42fc6c294368d7e..88229b4829aea7f0a4a9e68893c96f643e7944d1 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -569,7 +569,8 @@ int AudioProcessingImpl::InitializeLocked(const ProcessingConfig& config) {
submodule_states_.RenderMultiBandSubModulesActive());
// TODO(aluebs): Remove this restriction once we figure out why the 3-band
// splitting filter degrades the AEC performance.
- if (render_processing_rate > kSampleRate32kHz) {
+ if (render_processing_rate > kSampleRate32kHz &&
+ !config_.echo_canceller3.enabled) {
render_processing_rate = submodule_states_.RenderMultiBandProcessingActive()
? kSampleRate32kHz
: kSampleRate16kHz;
@@ -1440,9 +1441,7 @@ int AudioProcessingImpl::ProcessRenderStreamLocked() {
QueueRenderAudio(render_buffer);
// TODO(peah): Perform the queueing ínside QueueRenderAudiuo().
if (private_submodules_->echo_canceller3) {
- if (!private_submodules_->echo_canceller3->AnalyzeRender(render_buffer)) {
- // TODO(peah): Lock and empty render queue, and try again.
- }
+ private_submodules_->echo_canceller3->AnalyzeRender(render_buffer);
}
if (submodule_states_.RenderMultiBandProcessingActive() &&

Powered by Google App Engine
This is Rietveld 408576698