Major AEC3 render pipeline changes

webrtc/modules/audio_processing/aec3/echo_canceller3.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 53 matching lines @@
  public:
   // Normal c-tor to use.
   EchoCanceller3(int sample_rate_hz, bool use_highpass_filter);
   // Testing c-tor that is used only for testing purposes.
   EchoCanceller3(int sample_rate_hz,
                  bool use_highpass_filter,
                  std::unique_ptr<BlockProcessor> block_processor);
   ~EchoCanceller3();
   // Analyzes and stores an internal copy of the split-band domain render
   // signal.
-  bool AnalyzeRender(AudioBuffer* farend);
+  void AnalyzeRender(AudioBuffer* farend);

[peah-webrtc, 2017/03/30 05:36:56]

A bool is no longer returned as there is no sensible action to take when the
analysis was not successful.

   // Analyzes the full-band domain capture signal to detect signal saturation.
   void AnalyzeCapture(AudioBuffer* capture);
   // Processes the split-band domain capture signal in order to remove any echo
   // present in the signal.
   void ProcessCapture(AudioBuffer* capture, bool level_change);
 
   // Signals whether an external detector has detected echo leakage from the
   // echo canceller.
   // Note that in the case echo leakage has been flagged, it should be unflagged
   // once it is no longer occurring.
   void UpdateEchoLeakageStatus(bool leakage_detected) {
     RTC_DCHECK_RUNS_SERIALIZED(&capture_race_checker_);
     block_processor_->UpdateEchoLeakageStatus(leakage_detected);
   }
 
   // Validates a config.
   static bool Validate(const AudioProcessing::Config::EchoCanceller3& config);
   // Dumps a config to a string.
   static std::string ToString(
       const AudioProcessing::Config::EchoCanceller3& config);
 
  private:
   class RenderWriter;
 
-  // Empties the render SwapQueue. A bool is returned that indicates the success
-  // of the operation.
-  bool EmptyRenderQueue();
+  // Empties the render SwapQueue.
+  void EmptyRenderQueue();

[peah-webrtc, 2017/03/30 05:36:56]

A bool is no longer returned as there is no sensible action to take when the
emptying was not successful.

 
   rtc::RaceChecker capture_race_checker_;
   rtc::RaceChecker render_race_checker_;
 
   // State that is accessed by the AnalyzeRender call.
   std::unique_ptr<RenderWriter> render_writer_ GUARDED_BY(render_race_checker_);
 
   // State that may be accessed by the capture thread.
   static int instance_count_;
   std::unique_ptr<ApmDataDumper> data_dumper_;
@@ skipping 14 matching lines @@
   bool saturated_microphone_signal_ GUARDED_BY(capture_race_checker_) = false;
   std::vector<std::vector<float>> block_ GUARDED_BY(capture_race_checker_);
   std::vector<rtc::ArrayView<float>> sub_frame_view_
       GUARDED_BY(capture_race_checker_);
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoCanceller3);
 };
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC3_ECHO_CANCELLER3_H_