Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2782553005: Visualize events related to probing in the total bitrate graph. (Closed)
Patch Set: GRAPH --> CHART Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/event_log_visualizer/analyzer.h ('k') | webrtc/tools/event_log_visualizer/chart.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/event_log_visualizer/analyzer.cc
diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc
index c986ff7db9b2e640d825de0e5025754258a20d74..ba95c2565d7da640696c44dffc43829e2831a0a4 100644
--- a/webrtc/tools/event_log_visualizer/analyzer.cc
+++ b/webrtc/tools/event_log_visualizer/analyzer.cc
@@ -477,9 +477,12 @@ EventLogAnalyzer::EventLogAnalyzer(const ParsedRtcEventLog& log)
break;
}
case ParsedRtcEventLog::BWE_PROBE_CLUSTER_CREATED_EVENT: {
+ bwe_probe_cluster_created_events_.push_back(
+ parsed_log_.GetBweProbeClusterCreated(i));
break;
}
case ParsedRtcEventLog::BWE_PROBE_RESULT_EVENT: {
+ bwe_probe_result_events_.push_back(parsed_log_.GetBweProbeResult(i));
break;
}
case ParsedRtcEventLog::UNKNOWN_EVENT: {
@@ -938,7 +941,26 @@ void EventLogAnalyzer::CreateTotalBitrateGraph(
float y = static_cast<float>(bwe_update.new_bitrate) / 1000;
time_series->points.emplace_back(x, y);
}
+
+ TimeSeries* created_series =
+ plot->AddTimeSeries("Probe cluster created.", DOT_GRAPH);
+ for (auto& cluster : bwe_probe_cluster_created_events_) {
+ float x = static_cast<float>(cluster.timestamp - begin_time_) / 1000000;
+ float y = static_cast<float>(cluster.bitrate_bps) / 1000;
+ created_series->points.emplace_back(x, y);
+ }
+
+ TimeSeries* result_series =
+ plot->AddTimeSeries("Probing results.", DOT_GRAPH);
+ for (auto& result : bwe_probe_result_events_) {
+ if (result.bitrate_bps) {
+ float x = static_cast<float>(result.timestamp - begin_time_) / 1000000;
+ float y = static_cast<float>(*result.bitrate_bps) / 1000;
+ result_series->points.emplace_back(x, y);
+ }
+ }
}
+
plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 1, "Bitrate (kbps)", kBottomMargin, kTopMargin);
if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
« no previous file with comments | « webrtc/tools/event_log_visualizer/analyzer.h ('k') | webrtc/tools/event_log_visualizer/chart.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698