Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2782493003: MD Settings: Display languages native display name. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display languages native display name. BUG=703977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2782493003 Cr-Commit-Position: refs/heads/master@{#459981} Committed: https://chromium.googlesource.com/chromium/src/+/7afee7ca97509175ccc5f31bc8082c964af0ad04

Patch Set 1 : More #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/resources/settings/languages_page/add_languages_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.js View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
dpapad
Before/after screenshot http://imgur.com/a/SIfnP. I noticed that some native language names appear with a \n within ...
3 years, 9 months ago (2017-03-27 22:46:29 UTC) #6
Dan Beam
lgtm
3 years, 9 months ago (2017-03-28 00:21:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782493003/20001
3 years, 9 months ago (2017-03-28 00:28:09 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 02:04:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7afee7ca97509175ccc5f31bc808...

Powered by Google App Engine
This is Rietveld 408576698