webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc - Issue 2782423003: Major updates to the echo removal functionality in AEC3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc

Issue 2782423003: Major updates to the echo removal functionality in AEC3 (Closed)

Patch Set: Added initialization of uninitialized vector Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc

diff --git a/webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc b/webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc

index 16a36f4fb9e8378c3762b6a365e2002b395cf64a..ed1195996fe59c49ce8f910702a0c3731b229c90 100644

--- a/webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc

+++ b/webrtc/modules/audio_processing/aec3/echo_remover_metrics.cc

@@ -222,9 +222,6 @@ void EchoRemoverMetrics::Update(

"WebRTC.Audio.EchoCanceller.UsableLinearEstimate",

static_cast<int>(aec_state.UsableLinearEstimate() ? 1 : 0));

RTC_HISTOGRAM_BOOLEAN(

- "WebRTC.Audio.EchoCanceller.ModelBasedAecFeasible",

- static_cast<int>(aec_state.ModelBasedAecFeasible() ? 1 : 0));

- RTC_HISTOGRAM_BOOLEAN(

"WebRTC.Audio.EchoCanceller.ActiveRender",

static_cast<int>(

active_render_count_ > kMetricsCollectionBlocksBy2 ? 1 : 0));