Major updates to the echo removal functionality in AEC3

webrtc/modules/audio_processing/aec3/render_delay_buffer.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 84 matching lines @@
   size_t last_insert_index_ = 0;
   RenderBuffer fft_buffer_;
   DownsampledRenderBuffer downsampled_render_buffer_;
   DecimatorBy4 render_decimator_;
   ApiCallJitterBuffer api_call_jitter_buffer_;
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RenderDelayBufferImpl);
 };
 
 RenderDelayBufferImpl::RenderDelayBufferImpl(size_t num_bands)
     : optimization_(DetectOptimization()),
-      fft_buffer_(optimization_,
-                  num_bands,
-                  std::max(30, kAdaptiveFilterLength),
-                  std::vector<size_t>(1, kAdaptiveFilterLength)),
+      fft_buffer_(
+          optimization_,
+          num_bands,
+          std::max(kResidualEchoPowerRenderWindowSize, kAdaptiveFilterLength),
+          std::vector<size_t>(1, kAdaptiveFilterLength)),
       api_call_jitter_buffer_(num_bands) {
   buffer_.fill(std::vector<std::vector<float>>(
       num_bands, std::vector<float>(kBlockSize, 0.f)));
 
   RTC_DCHECK_LT(buffer_.size(), downsampled_render_buffer_.buffer.size());
 }
 
 RenderDelayBufferImpl::~RenderDelayBufferImpl() = default;
 
 void RenderDelayBufferImpl::Reset() {
@@ skipping 49 matching lines @@
 }
 
 void RenderDelayBufferImpl::SetDelay(size_t delay) {
   if (delay_ == delay) {
     return;
   }
 
   // If there is a new delay set, clear the fft buffer.
   fft_buffer_.Clear();
 
-  const size_t max_delay = buffer_.size() - 1;
-  if (max_delay < delay) {
+  if ((buffer_.size() - 1) < delay) {
     // If the desired delay is larger than the delay buffer, shorten the delay
     // buffer size to achieve the desired alignment with the available buffer
     // size.
-    const size_t delay_decrease = delay - max_delay;
-    RTC_DCHECK_LT(delay_decrease, buffer_.size());
-
     downsampled_render_buffer_.position =
-        (downsampled_render_buffer_.position + kSubBlockSize * delay_decrease) %
+        (downsampled_render_buffer_.position +
+         kSubBlockSize * (delay - (buffer_.size() - 1))) %
         downsampled_render_buffer_.buffer.size();
 
     last_insert_index_ =
-        (last_insert_index_ + buffer_.size() - delay_decrease) % buffer_.size();
-
-    RTC_DCHECK_EQ(max_delay, delay_ - delay_decrease);
-    delay_ = max_delay;
+        (last_insert_index_ - (delay - (buffer_.size() - 1)) + buffer_.size()) %
+        buffer_.size();
+    delay_ = buffer_.size() - 1;
   } else {
     delay_ = delay;
   }
 }
 
 }  // namespace
 
 RenderDelayBuffer* RenderDelayBuffer::Create(size_t num_bands) {
   return new RenderDelayBufferImpl(num_bands);
 }
 
 }  // namespace webrtc