Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2782273002: Fixing some case-sensitive codec name comparisons. (Closed)
Patch Set: Adding PeerConnection integration test for codec name casing. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_receive_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 73247d8d4ee24b9715d52e7014bcf95c9ccfbc36..2cef1fcab35512708cb0e591e6ec9533259b8af1 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -263,9 +263,14 @@ std::string VideoSendStream::StreamStats::ToString() const {
namespace {
bool PayloadTypeSupportsSkippingFecPackets(const std::string& payload_name) {
- if (payload_name == "VP8" || payload_name == "VP9")
+ rtc::Optional<VideoCodecType> codecType =
+ PayloadNameToCodecType(payload_name);
+ if (codecType &&
+ (*codecType == kVideoCodecVP8 || *codecType == kVideoCodecVP9)) {
return true;
- RTC_DCHECK(payload_name == "H264" || payload_name == "FAKE")
+ }
+ RTC_DCHECK((codecType && *codecType == kVideoCodecH264) ||
+ payload_name == "FAKE")
<< "unknown payload_name " << payload_name;
return false;
}
« no previous file with comments | « webrtc/video/video_receive_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698