Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: PRESUBMIT.py

Issue 2780943003: Move video_encoder.h and video_decoder.h to /api and create GN targets for them (Closed)
Patch Set: Fix lint warnings Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 20 matching lines...) Expand all
31 'webrtc/p2p', 31 'webrtc/p2p',
32 'webrtc/pc', 32 'webrtc/pc',
33 'webrtc/sdk/android/src/jni', 33 'webrtc/sdk/android/src/jni',
34 'webrtc/sdk/objc', 34 'webrtc/sdk/objc',
35 'webrtc/system_wrappers', 35 'webrtc/system_wrappers',
36 'webrtc/test', 36 'webrtc/test',
37 'webrtc/voice_engine', 37 'webrtc/voice_engine',
38 'webrtc/call.h', 38 'webrtc/call.h',
39 'webrtc/common_types.h', 39 'webrtc/common_types.h',
40 'webrtc/common_types.cc', 40 'webrtc/common_types.cc',
41 'webrtc/video_decoder.h', 41 'webrtc/api/video_decoder.h',
the sun 2017/03/30 08:10:36 1. List should be sorted. 2. Move the files to web
ilnik 2017/03/30 11:15:57 Done.
42 'webrtc/video_encoder.h', 42 'webrtc/api/video_encoder.h',
43 'webrtc/video_send_stream.h', 43 'webrtc/video_send_stream.h',
44 ] 44 ]
45 45
46 # These filters will always be removed, even if the caller specifies a filter 46 # These filters will always be removed, even if the caller specifies a filter
47 # set, as they are problematic or broken in some way. 47 # set, as they are problematic or broken in some way.
48 # 48 #
49 # Justifications for each filter: 49 # Justifications for each filter:
50 # - build/c++11 : Rvalue ref checks are unreliable (false positives), 50 # - build/c++11 : Rvalue ref checks are unreliable (false positives),
51 # include file and feature blacklists are 51 # include file and feature blacklists are
52 # google3-specific. 52 # google3-specific.
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 input_api, output_api)) 575 input_api, output_api))
576 results.extend(input_api.canned_checks.CheckChangeHasDescription( 576 results.extend(input_api.canned_checks.CheckChangeHasDescription(
577 input_api, output_api)) 577 input_api, output_api))
578 results.extend(_CheckChangeHasBugField(input_api, output_api)) 578 results.extend(_CheckChangeHasBugField(input_api, output_api))
579 results.extend(input_api.canned_checks.CheckChangeHasTestField( 579 results.extend(input_api.canned_checks.CheckChangeHasTestField(
580 input_api, output_api)) 580 input_api, output_api))
581 results.extend(input_api.canned_checks.CheckTreeIsOpen( 581 results.extend(input_api.canned_checks.CheckTreeIsOpen(
582 input_api, output_api, 582 input_api, output_api,
583 json_url='http://webrtc-status.appspot.com/current?format=json')) 583 json_url='http://webrtc-status.appspot.com/current?format=json'))
584 return results 584 return results
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698