Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: webrtc/voice_engine/channel_proxy.cc

Issue 2780473002: Fix UT failure by temporarily uncommenting (Closed)
Patch Set: Added issue number to TODOs. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/audio/audio_send_stream.cc ('K') | « webrtc/audio/audio_send_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/channel_proxy.cc
diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc
index 45cbf10819b29829684d148cc3cd062359d2c380..c72b32a081c901dea3eb7ae03e7593c5c3862bc0 100644
--- a/webrtc/voice_engine/channel_proxy.cc
+++ b/webrtc/voice_engine/channel_proxy.cc
@@ -368,13 +368,14 @@ bool ChannelProxy::SetSendCNPayloadType(int type,
}
void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) {
- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
+ // TODO(elad.alon): This fails in UT; fix and uncomment. (WebRTC issue 7405.)
+ // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate);
}
void ChannelProxy::OnRecoverableUplinkPacketLossRate(
float recoverable_packet_loss_rate) {
- // TODO(elad.alon): This fails in UT; fix and uncomment.
+ // TODO(elad.alon): This fails in UT; fix and uncomment. (WebRTC issue 7405.)
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate);
}
« webrtc/audio/audio_send_stream.cc ('K') | « webrtc/audio/audio_send_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698