Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: webrtc/audio/audio_send_stream.cc

Issue 2780473002: Fix UT failure by temporarily uncommenting (Closed)
Patch Set: Added issue number to TODOs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/voice_engine/channel_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 rtc::CritScope lock(&packet_loss_tracker_cs_); 267 rtc::CritScope lock(&packet_loss_tracker_cs_);
268 // TODO(elad.alon): This function call could potentially reset the window, 268 // TODO(elad.alon): This function call could potentially reset the window,
269 // setting both PLR and RPLR to unknown. Consider (during upcoming 269 // setting both PLR and RPLR to unknown. Consider (during upcoming
270 // refactoring) passing an indication of such an event. 270 // refactoring) passing an indication of such an event.
271 packet_loss_tracker_.OnPacketAdded(seq_num, rtc::TimeMillis()); 271 packet_loss_tracker_.OnPacketAdded(seq_num, rtc::TimeMillis());
272 } 272 }
273 } 273 }
274 274
275 void AudioSendStream::OnPacketFeedbackVector( 275 void AudioSendStream::OnPacketFeedbackVector(
276 const std::vector<PacketFeedback>& packet_feedback_vector) { 276 const std::vector<PacketFeedback>& packet_feedback_vector) {
277 // TODO(elad.alon): This fails in UT; fix and uncomment. 277 // TODO(elad.alon): This fails in UT; fix and uncomment. (WebRTC issue 7405.)
the sun 2017/03/27 14:30:29 Super nit: Referring to issues in this format is n
elad.alon_webrtc.org 2017/03/27 14:55:44 Will do.
278 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 278 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
279 rtc::Optional<float> plr; 279 rtc::Optional<float> plr;
280 rtc::Optional<float> rplr; 280 rtc::Optional<float> rplr;
281 { 281 {
282 rtc::CritScope lock(&packet_loss_tracker_cs_); 282 rtc::CritScope lock(&packet_loss_tracker_cs_);
283 packet_loss_tracker_.OnPacketFeedbackVector(packet_feedback_vector); 283 packet_loss_tracker_.OnPacketFeedbackVector(packet_feedback_vector);
284 plr = packet_loss_tracker_.GetPacketLossRate(); 284 plr = packet_loss_tracker_.GetPacketLossRate();
285 rplr = packet_loss_tracker_.GetRecoverablePacketLossRate(); 285 rplr = packet_loss_tracker_.GetRecoverablePacketLossRate();
286 } 286 }
287 // TODO(elad.alon): If R/PLR go back to unknown, no indication is given that 287 // TODO(elad.alon): If R/PLR go back to unknown, no indication is given that
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 LOG(LS_WARNING) << "SetVADStatus() failed."; 421 LOG(LS_WARNING) << "SetVADStatus() failed.";
422 return false; 422 return false;
423 } 423 }
424 } 424 }
425 } 425 }
426 return true; 426 return true;
427 } 427 }
428 428
429 } // namespace internal 429 } // namespace internal
430 } // namespace webrtc 430 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/voice_engine/channel_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698