Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: webrtc/examples/BUILD.gn

Issue 2780433006: Fix deprecated methods in AppRTCMobile. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index 782491d42511a67d77a85905eb77247942403b83..ebe426f00c18cbcdb494747398c42a7bdf89c4f3 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -150,23 +150,6 @@ if (is_android) {
}
if (is_ios || (is_mac && target_cpu != "x86")) {
- config("warnings_config") {
- # GN orders flags on a target before flags from configs. The default config
- # adds these flags so to cancel them out they need to come from a config and
- # cannot be on the target directly.
- if (is_ios) {
- # Suppress compiler warnings about deprecated that triggered
- # when moving from ios_deployment_target 7.0 to 9.0.
- # See webrtc:5549 for more details.
- cflags = [ "-Wno-deprecated-declarations" ]
- cflags_objc = [
- # Enabled for cflags_objc in build/config/compiler/BUILD.gn.
- # See webrtc:6520.
- "-Wno-objc-missing-property-synthesis",
- ]
- }
- }
-
config("apprtc_common_config") {
include_dirs = [ "objc/AppRTCMobile/common" ]
}
@@ -177,10 +160,7 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCMobile/common/ARDUtilities.h",
"objc/AppRTCMobile/common/ARDUtilities.m",
]
- configs += [
- ":warnings_config",
- "//build/config/compiler:enable_arc",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
public_configs = [ ":apprtc_common_config" ]
deps = [
@@ -245,10 +225,7 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCMobile/RTCSessionDescription+JSON.h",
"objc/AppRTCMobile/RTCSessionDescription+JSON.m",
]
- configs += [
- "//build/config/compiler:enable_arc",
- ":warnings_config",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
public_configs = [ ":apprtc_signaling_config" ]
deps = [
":apprtc_common",
@@ -281,10 +258,7 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.h",
"objc/AppRTCMobile/ios/UIImage+ARDUtilities.m",
]
- configs += [
- "//build/config/compiler:enable_arc",
- ":warnings_config",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
deps = [
":apprtc_common",

Powered by Google App Engine
This is Rietveld 408576698