Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: webrtc/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc

Issue 2779843005: Disable flaky TestVp9Impl.EncodeDecode for iOS. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 VideoCodec codec_settings() override { 23 VideoCodec codec_settings() override {
24 VideoCodec codec_inst; 24 VideoCodec codec_inst;
25 codec_inst.codecType = webrtc::kVideoCodecVP9; 25 codec_inst.codecType = webrtc::kVideoCodecVP9;
26 codec_inst.VP9()->numberOfTemporalLayers = 1; 26 codec_inst.VP9()->numberOfTemporalLayers = 1;
27 codec_inst.VP9()->numberOfSpatialLayers = 1; 27 codec_inst.VP9()->numberOfSpatialLayers = 1;
28 return codec_inst; 28 return codec_inst;
29 } 29 }
30 }; 30 };
31 31
32 // Disabled on ios as flake, see https://crbug.com/webrtc/7057
33 #if defined(WEBRTC_IOS)
34 TEST_F(TestVp9Impl, DISABLED_EncodeDecode) {
35 #else
32 TEST_F(TestVp9Impl, EncodeDecode) { 36 TEST_F(TestVp9Impl, EncodeDecode) {
37 #endif
33 EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, 38 EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK,
34 encoder_->Encode(*input_frame_, nullptr, nullptr)); 39 encoder_->Encode(*input_frame_, nullptr, nullptr));
35 EncodedImage encoded_frame; 40 EncodedImage encoded_frame;
36 ASSERT_TRUE(WaitForEncodedFrame(&encoded_frame)); 41 ASSERT_TRUE(WaitForEncodedFrame(&encoded_frame));
37 // First frame should be a key frame. 42 // First frame should be a key frame.
38 encoded_frame._frameType = kVideoFrameKey; 43 encoded_frame._frameType = kVideoFrameKey;
39 EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, 44 EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK,
40 decoder_->Decode(encoded_frame, false, nullptr)); 45 decoder_->Decode(encoded_frame, false, nullptr));
41 std::unique_ptr<VideoFrame> decoded_frame; 46 std::unique_ptr<VideoFrame> decoded_frame;
42 rtc::Optional<uint8_t> decoded_qp; 47 rtc::Optional<uint8_t> decoded_qp;
(...skipping 13 matching lines...) Expand all
56 decoder_->Decode(encoded_frame, false, nullptr)); 61 decoder_->Decode(encoded_frame, false, nullptr));
57 std::unique_ptr<VideoFrame> decoded_frame; 62 std::unique_ptr<VideoFrame> decoded_frame;
58 rtc::Optional<uint8_t> decoded_qp; 63 rtc::Optional<uint8_t> decoded_qp;
59 ASSERT_TRUE(WaitForDecodedFrame(&decoded_frame, &decoded_qp)); 64 ASSERT_TRUE(WaitForDecodedFrame(&decoded_frame, &decoded_qp));
60 ASSERT_TRUE(decoded_frame); 65 ASSERT_TRUE(decoded_frame);
61 ASSERT_TRUE(decoded_qp); 66 ASSERT_TRUE(decoded_qp);
62 EXPECT_EQ(encoded_frame.qp_, *decoded_qp); 67 EXPECT_EQ(encoded_frame.qp_, *decoded_qp);
63 } 68 }
64 69
65 } // namespace webrtc 70 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698