Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.cc

Issue 2778783002: AecDump interface (Closed)
Patch Set: Comment formatting. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.cc
diff --git a/webrtc/modules/audio_processing/include/audio_processing.cc b/webrtc/modules/audio_processing/include/audio_processing.cc
index 9a3b84dd0ce27a31f7354dfc296686170b3019dd..eec4db61795c9f082359e397c96ebb3763f13f39 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.cc
+++ b/webrtc/modules/audio_processing/include/audio_processing.cc
@@ -10,6 +10,11 @@
#include "webrtc/modules/audio_processing/include/audio_processing.h"
+#include "webrtc/base/checks.h"
+#include "webrtc/modules/audio_processing/include/aec_dump.h"
+// TODO(aleloi): remove AecDump header usage when internal projcets
+// have updated. See https://bugs.webrtc.org/7404.
+
namespace webrtc {
Beamforming::Beamforming()
@@ -31,4 +36,20 @@ Beamforming::Beamforming(bool enabled,
Beamforming::~Beamforming() {}
+// TODO(aleloi): make pure virtual when internal projects have
+// updated. See https://bugs.webrtc.org/7404
+void AudioProcessing::AttachAecDump(std::unique_ptr<AecDump> aec_dump) {
+ RTC_NOTREACHED();
+}
+
+// If no AecDump is attached, this has no effect. If an AecDump is
+// attached, it's destructor is called. The d-tor may block until
+// all pending logging tasks are completed.
+//
+// TODO(aleloi): make pure virtual when internal projects have
+// updated. See https://bugs.webrtc.org/7404
+void AudioProcessing::DetachAecDump() {
+ RTC_NOTREACHED();
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698