AecDump interface

webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h

Index: webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
diff --git a/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h b/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..a1260b7c9b98a3b053f3c1add156623b8d34d51c
--- /dev/null
+++ b/webrtc/modules/audio_processing/aec_dump/aec_dump_factory.h
@@ -0,0 +1,39 @@
+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_
+
+#include <memory>
+#include <string>
+
+#include "webrtc/modules/audio_processing/include/aec_dump.h"
+
+namespace rtc {
+class TaskQueue;
+}  // namespace rtc
+
+namespace webrtc {
+
+class AecDumpFactory {
+ public:
+  // Creates new AecDump that does file IO on the provided
+  // task queue. The task queue must outlive the created AecDump instance.
+  static std::unique_ptr<AecDump> Create(std::string file_name,

[peah-webrtc, 2017/04/07 12:57:15]

Why is a class needed for this? Or is more functionality to be added?

[aleloi, 2017/04/12 11:05:29]

It's gone now, because this CL doesn't create real AecDump instances. I added it
originally to not add more ::Create methods to the webrtc namespace. The choice
was between new namespace or static methods in a new class. 

+                                         int64_t max_log_size_bytes,
+                                         rtc::TaskQueue* worker_queue);
+  static std::unique_ptr<AecDump> Create(FILE* handle,
+                                         int64_t max_log_size_bytes,
+                                         rtc::TaskQueue* worker_queue);
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC_DUMP_AEC_DUMP_FACTORY_H_