AecDump interface

webrtc/modules/audio_processing/include/audio_processing.h

Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index ab924b75343e5d9c086e6a689ca7726b6e830c3d..84f92fb03c4ad5f590c52e7a848af1ad621ad8b3 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -25,6 +25,10 @@
 #include "webrtc/modules/audio_processing/include/config.h"
 #include "webrtc/typedefs.h"
 
+namespace rtc {
+class TaskQueue;
+}  // namespace rtc
+
 namespace webrtc {
 
 struct AecCore;
@@ -454,21 +458,29 @@ class AudioProcessing {
   // file size (in bytes) for the log can be specified. The logging is stopped
   // once the limit has been reached. If max_log_size_bytes is set to a value
   // <= 0, no limit will be used.
+  // When the AecDumper submodule is implemented, the file IO will be done on
+  // the passed task queue. Currently the worker queue is not used.
   static const size_t kMaxFilenameSize = 1024;
   virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
-                                  int64_t max_log_size_bytes) = 0;
+                                  int64_t max_log_size_bytes,
+                                  rtc::TaskQueue* worker_queue) = 0;

[peah-webrtc, 2017/03/31 07:24:43]

These API changes will probably break quite a number of downstream dependencies.

[aleloi, 2017/04/06 15:46:11]

I've added a new one as suggested by solenberg@ instead of changing the old
ones.

 
   // Same as above but uses an existing file handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
-  virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
+  virtual int StartDebugRecording(FILE* handle,
+                                  int64_t max_log_size_bytes,
+                                  rtc::TaskQueue* worker_queue) = 0;
 
   // TODO(ivoc): Remove this function after Chrome stops using it.
-  virtual int StartDebugRecording(FILE* handle) = 0;
+  virtual int StartDebugRecording(FILE* handle,
+                                  rtc::TaskQueue* worker_queue) = 0;
 
   // Same as above but uses an existing PlatformFile handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
   // TODO(xians): Make this interface pure virtual.
-  virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) = 0;
+  virtual int StartDebugRecordingForPlatformFile(
+      rtc::PlatformFile handle,
+      rtc::TaskQueue* worker_queue) = 0;
 
   // Stops recording debugging information, and closes the file. Recording
   // cannot be resumed in the same file (without overwriting it).