AecDump interface

webrtc/modules/audio_processing/aec_dumper/no_pb_aec_dumper.cc

Index: webrtc/modules/audio_processing/aec_dumper/no_pb_aec_dumper.cc
diff --git a/webrtc/modules/audio_processing/aec_dumper/no_pb_aec_dumper.cc b/webrtc/modules/audio_processing/aec_dumper/no_pb_aec_dumper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..40ec41a1abae5c6fe01f695ac724bc5764c24cf1
--- /dev/null
+++ b/webrtc/modules/audio_processing/aec_dumper/no_pb_aec_dumper.cc
@@ -0,0 +1,28 @@
+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/audio_processing/aec_dumper/aec_dumper.h"

[peah-webrtc, 2017/03/31 07:24:43]

As I see it, there are two alternatives to include "empty" aecdump
functionality:
1) Use #if/#endif-s in the code to separate the two cases.
2) Select what code to include from the build-file.

I personally prefer 1) as that does not require the reader of the code to read
the buildfiles to see what is happening. Furthermore, I have a feeling that it
is easier to test for that.

Have you considered doing this using 1) instead? What drawbacks/advantages do
you see between 1) and 2)?

[aleloi, 2017/04/06 15:46:11]

I would almost always prefer virtual functions to the pre-processor. Advantages
are (specific to this case): less logic in one place (audio_processing_impl), it
forces to think about abstractions and division of responsibility. IMHO, it is
actually *easier* to read and to test, because the interface can be mocked.

+
+#include "webrtc/modules/audio_processing/aec_dumper/null_aec_dumper.h"
+
+namespace webrtc {
+
+std::unique_ptr<AecDumper> AecDumper::Create(std::string file_name,
+                                             int64_t max_log_size_bytes,
+                                             rtc::TaskQueue* worker_queue) {
+  return AecDumper::CreateNullDumper();
+}
+
+std::unique_ptr<AecDumper> AecDumper::Create(FILE* handle,
+                                             int64_t max_log_size_bytes,
+                                             rtc::TaskQueue* worker_queue) {
+  return AecDumper::CreateNullDumper();
+}
+}  // namespace webrtc