AecDump interface

webrtc/modules/audio_processing/aec_dumper/BUILD.gn

Index: webrtc/modules/audio_processing/aec_dumper/BUILD.gn
diff --git a/webrtc/modules/audio_processing/aec_dumper/BUILD.gn b/webrtc/modules/audio_processing/aec_dumper/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..a3b3c86074be25ea22eec5c90d326b415d9f2d2b
--- /dev/null
+++ b/webrtc/modules/audio_processing/aec_dumper/BUILD.gn
@@ -0,0 +1,72 @@
+import("//third_party/protobuf/proto_library.gni")
+import("../../../webrtc.gni")

[peah-webrtc, 2017/03/31 07:24:42]

Should there be a separate build target for this?

[aleloi, 2017/04/06 15:46:10]

I think it's best: it disconnects the APM from the logging,  allows different
implementations of AecDump, reduces compilation time and allows better use of GN
(e.g. more header checks, fine-grained dependencies, check that protobuf must be
enabled to use the aec_dumper_impl and that two different AecDump factory impls
may not be included at once).

+
+rtc_source_set("aec_dumper") {
+  # Includes audio_processing.h TODO(aleloi): add a dependency for
+  # that when the header is not part of ..:audio_processing.
+  check_includes = false
+
+  # Will be removed once implementation is added.
+  assert_no_deps = [ ":aec_dumper_impl" ]
+
+  sources = [
+    "aec_dumper.cc",
+    "aec_dumper.h",
+    "null_aec_dumper.h",
+  ]
+
+  # Only targets in this file and audio_processing/ can depend on
+  # this.
+  visibility = [
+    "../:*",
+    ":*",
+  ]
+
+  deps = []
+}
+
+rtc_source_set("aec_dumper_impl") {
+  assert_no_deps = [ ":aec_dumper_no_pb" ]
+
+  # Will be added later
+  sources = []
+  deps = []
+
+  # When completed, it will not compile without protobuf support.
+  if (rtc_enable_protobuf) {
+    deps += [ "../:audioproc_debug_proto" ]
+  }
+}
+
+rtc_source_set("aec_dumper_no_pb") {
+  assert_no_deps = [ ":aec_dumper_impl" ]
+  sources = [
+    "no_pb_aec_dumper.cc",
+  ]
+  deps = [
+    ":aec_dumper",
+  ]
+}
+
+rtc_source_set("aec_dumper_unittests") {
+  testonly = true
+  deps = [
+    ":aec_dumper",
+    ":aec_dumper_no_pb",
+    "../../../base:rtc_task_queue",
+    "../../../test:test_support",
+    "//testing/gtest",
+  ]
+  sources = []
+  if (rtc_enable_protobuf) {
+    deps += [
+      ":aec_dumper_impl",
+      # Might be added later:
+      # "..:audioproc_protobuf_utils",
+      # "..:audioproc_unittest_proto",
+    ]
+  } else {
+    deps += [ ":aec_dumper_no_pb" ]
+  }
+  sources += [ "aec_dumper_unittest.cc" ]
+}