AecDump interface

webrtc/media/engine/webrtcvoiceengine.cc

 /*
  *  Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 981 matching lines @@
                                      int64_t max_size_bytes) {
   RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
   FILE* aec_dump_file_stream = rtc::FdopenPlatformFileForWriting(file);
   if (!aec_dump_file_stream) {
     LOG(LS_ERROR) << "Could not open AEC dump file stream.";
     if (!rtc::ClosePlatformFile(file))
       LOG(LS_WARNING) << "Could not close file.";
     return false;
   }
   StopAecDump();
-  if (apm()->StartDebugRecording(aec_dump_file_stream, max_size_bytes) !=
+  if (apm()->StartDebugRecording(aec_dump_file_stream, max_size_bytes,

[the sun, 2017/03/28 22:35:29]

Could we get rid of these calls on the APM and just have one which sets the
AecDumper implementation? Then we could just have one method on
WebRtcVoiceEngine too - creating a dumper for either of rtc::PlatformFile or a
file name would be handled higher up the stack and we'd not need to know about
such details here...

[aleloi, 2017/04/06 15:46:10]

Sure! I've added a new APM::StartDebugRecording method that takes an AecDump.
However, I havn't changed anything here and not deprecated the old ones. This CL
doesn't contain the implementation of AecDump yet, and
StartDebugRecording(AecDump) does nothing. Therefore the old calls are still
here.

+                                 nullptr) !=
       webrtc::AudioProcessing::kNoError) {
     LOG_RTCERR0(StartDebugRecording);
     fclose(aec_dump_file_stream);
     return false;
   }
   is_dumping_aec_ = true;
   return true;
 }
 
 void WebRtcVoiceEngine::StartAecDump(const std::string& filename) {
   RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
   if (!is_dumping_aec_) {
     // Start dumping AEC when we are not dumping.
-    if (apm()->StartDebugRecording(filename.c_str(), -1) !=
+    if (apm()->StartDebugRecording(filename.c_str(), -1, nullptr) !=
         webrtc::AudioProcessing::kNoError) {
       LOG_RTCERR1(StartDebugRecording, filename.c_str());
     } else {
       is_dumping_aec_ = true;
     }
   }
 }
 
 void WebRtcVoiceEngine::StopAecDump() {
   RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
@@ skipping 1599 matching lines @@
                       ssrc);
   if (it != unsignaled_recv_ssrcs_.end()) {
     unsignaled_recv_ssrcs_.erase(it);
     return true;
   }
   return false;
 }
 }  // namespace cricket
 
 #endif  // HAVE_WEBRTC_VOICE