Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2778653002: Alphabetically sort RuntimeEnabledFeatures.json5. (Closed)

Created:
3 years, 9 months ago by Matt Giuca
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, kinuko+watch, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Alphabetically sort RuntimeEnabledFeatures.json5. Adds a presubmit check to make sure it stays sorted. Review-Url: https://codereview.chromium.org/2778653002 Cr-Commit-Position: refs/heads/master@{#459975} Committed: https://chromium.googlesource.com/chromium/src/+/f6dcc1b92feaa2f36babb2bc86b30acbd308aa99

Patch Set 1 #

Patch Set 2 : Added PRESUBMIT check to keep it sorted. #

Patch Set 3 : Line length. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -162 lines) Patch
A third_party/WebKit/Source/platform/PRESUBMIT.py View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 31 chunks +162 lines, -162 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Matt Giuca
Hi Kent, This file is kinda-sorta-alphabetical which makes it hard to figure out where to ...
3 years, 9 months ago (2017-03-27 06:40:24 UTC) #2
tkent
lgtm On 2017/03/27 at 06:40:24, mgiuca wrote: > But those names (at least the last ...
3 years, 9 months ago (2017-03-27 06:47:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778653002/60001
3 years, 9 months ago (2017-03-28 00:06:24 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 01:49:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f6dcc1b92feaa2f36babb2bc86b3...

Powered by Google App Engine
This is Rietveld 408576698