Enable trendline experiment and bayesian bitrate estimator experiment by default.

webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 114 matching lines @@
   EXPECT_NE(interval_ms, default_interval_ms);
 }
 
 TEST_F(DelayBasedBweTest, InitialBehavior) {
   InitialBehaviorTestHelper(674840);
 }
 
 TEST_F(DelayBasedBweTest, RateIncreaseReordering) {
   RateIncreaseReorderingTestHelper(674840);
 }
-
 TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) {
   RateIncreaseRtpTimestampsTestHelper(1240);
 }
 
 TEST_F(DelayBasedBweTest, CapacityDropOneStream) {
-  CapacityDropTestHelper(1, false, 567, 0);
+  CapacityDropTestHelper(1, false, 600, 0);
 }
 
 TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
-  CapacityDropTestHelper(1, false, 200, 30000);
+  CapacityDropTestHelper(1, false, 767, 30000);

[terelius, 2017/03/28 12:18:21]

Are you happy with the new values?

[stefan-webrtc, 2017/03/30 08:30:47]

I think they are fine. They will change again once both this and the bayesian
estimator lands.

 }
 
 TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) {
-  CapacityDropTestHelper(1, false, 733, -30000);
+  CapacityDropTestHelper(1, false, 1400, -30000);
 }
 
 TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) {
-  CapacityDropTestHelper(1, true, 567, 0);
+  CapacityDropTestHelper(1, true, 600, 0);
 }
-
 TEST_F(DelayBasedBweTest, TestTimestampGrouping) {
   TestTimestampGroupingTestHelper();
 }
 
 TEST_F(DelayBasedBweTest, TestShortTimeoutAndWrap) {
   // Simulate a client leaving and rejoining the call after 35 seconds. This
   // will make abs send time wrap, so if streams aren't timed out properly
   // the next 30 seconds of packets will be out of order.
   TestWrappingHelper(35);
 }
 
 TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) {
   // Simulate a client leaving and rejoining the call after some multiple of
   // 64 seconds later. This will cause a zero difference in abs send times due
   // to the wrap, but a big difference in arrival time, if streams aren't
   // properly timed out.
   TestWrappingHelper(10 * 64);
 }
 
 class DelayBasedBweExperimentTest : public DelayBasedBweTest {

[terelius, 2017/03/28 12:18:21]

Shouldn't this be removed and ImprovedBitrateEstimate be enabled by default?

[stefan-webrtc, 2017/03/30 08:30:47]

That ended up being a separate CL, but yes, both will be default once this is
done.

  public:
   DelayBasedBweExperimentTest()
       : override_field_trials_("WebRTC-ImprovedBitrateEstimate/Enabled/") {
     bitrate_estimator_.reset(new DelayBasedBwe(nullptr, &clock_));
   }
 
  private:
   test::ScopedFieldTrials override_field_trials_;
 };
 
 TEST_F(DelayBasedBweExperimentTest, RateIncreaseRtpTimestamps) {
   RateIncreaseRtpTimestampsTestHelper(1288);
 }
 
 TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStream) {
   CapacityDropTestHelper(1, false, 333, 0);
 }
 
 TEST_F(DelayBasedBweExperimentTest, CapacityDropPosOffsetChange) {
-  CapacityDropTestHelper(1, false, 300, 30000);
+  CapacityDropTestHelper(1, false, 867, 30000);
 }
 
 TEST_F(DelayBasedBweExperimentTest, CapacityDropNegOffsetChange) {
-  CapacityDropTestHelper(1, false, 300, -30000);
+  CapacityDropTestHelper(1, false, 867, -30000);
 }
 
 TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStreamWrap) {
   CapacityDropTestHelper(1, true, 333, 0);
 }
 
-class DelayBasedBweTrendlineExperimentTest : public DelayBasedBweTest {
- public:
-  DelayBasedBweTrendlineExperimentTest()
-      : override_field_trials_("WebRTC-BweTrendlineFilter/Enabled-15,0.9,4/") {
-    bitrate_estimator_.reset(new DelayBasedBwe(nullptr, &clock_));
-  }
-
- private:
-  test::ScopedFieldTrials override_field_trials_;
-};
-
-TEST_F(DelayBasedBweTrendlineExperimentTest, RateIncreaseRtpTimestamps) {
-  RateIncreaseRtpTimestampsTestHelper(1240);
-}
-
-TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStream) {
-  CapacityDropTestHelper(1, false, 600, 0);
-}
-
-TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropPosOffsetChange) {
-  CapacityDropTestHelper(1, false, 600, 30000);
-}
-
-TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropNegOffsetChange) {
-  CapacityDropTestHelper(1, false, 1267, -30000);
-}
-
-TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStreamWrap) {
-  CapacityDropTestHelper(1, true, 600, 0);
-}
-
 class DelayBasedBweMedianSlopeExperimentTest : public DelayBasedBweTest {
  public:
   DelayBasedBweMedianSlopeExperimentTest()
       : override_field_trials_("WebRTC-BweMedianSlopeFilter/Enabled-20,4/") {
     bitrate_estimator_.reset(new DelayBasedBwe(nullptr, &clock_));
   }
 
  private:
   test::ScopedFieldTrials override_field_trials_;
 };
@@ skipping 12 matching lines @@
 
 TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropNegOffsetChange) {
   CapacityDropTestHelper(1, false, 1267, -30000);
 }
 
 TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStreamWrap) {
   CapacityDropTestHelper(1, true, 600, 0);
 }
 
 }  // namespace webrtc