Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2777203003: Android: Remove codec thread from MediaCodecVideoDecoder. (Closed)

Created:
3 years, 8 months ago by sakal
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG=webrtc:7439, chromium:695438

Patch Set 1 : Cleanup #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -132 lines) Patch
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoDecoder.java View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc View 1 22 chunks +52 lines, -130 lines 0 comments Download

Messages

Total messages: 33 (27 generated)
sakal
PTAL
3 years, 8 months ago (2017-03-28 13:59:40 UTC) #20
tommi
exciting! :D Btw, this change might address a performance regression we saw on the nexus ...
3 years, 8 months ago (2017-03-28 14:35:02 UTC) #21
magjed_webrtc
lgtm
3 years, 8 months ago (2017-03-28 15:00:16 UTC) #23
tommi
On 2017/03/28 15:00:16, magjed_webrtc wrote: > lgtm lgtm - fyi - I've sent this patch ...
3 years, 8 months ago (2017-04-04 10:20:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2777203003/120001
3 years, 8 months ago (2017-04-04 10:55:19 UTC) #28
tommi
3 years, 8 months ago (2017-04-11 13:09:16 UTC) #33
On 2017/04/04 10:55:19, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

I'll include this change with the other one, as the other one got reverted.  CL
here:
https://codereview.webrtc.org/2811963004/

Powered by Google App Engine
This is Rietveld 408576698