|
|
DescriptionAndroid: Remove codec thread from MediaCodecVideoDecoder.
All calls to the decoder will be made on the same thread expect for
release. Calling release on a different thread should be safe because the
decoder thread has already been stopped.
BUG=webrtc:7439, chromium:695438
Patch Set 1 : Cleanup #Patch Set 2 : Rebase. #
Messages
Total messages: 33 (27 generated)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/18993) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24279) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/23094)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...) presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15466)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15468)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Description was changed from ========== WIP: Test removal of the codec thread. BUG= ========== to ========== Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG= ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
exciting! :D Btw, this change might address a performance regression we saw on the nexus 9 bot(s): https://bugs.chromium.org/p/chromium/issues/detail?id=695438
Description was changed from ========== Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG= ========== to ========== Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG=chromium:695438 ==========
lgtm
On 2017/03/28 15:00:16, magjed_webrtc wrote: > lgtm lgtm - fyi - I've sent this patch to the cq now: https://codereview.webrtc.org/2764573002
Description was changed from ========== Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG=chromium:695438 ========== to ========== Android: Remove codec thread from MediaCodecVideoDecoder. All calls to the decoder will be made on the same thread expect for release. Calling release on a different thread should be safe because the decoder thread has already been stopped. BUG=webrtc:7439, chromium:695438 ==========
The CQ bit was checked by tommi@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org, tommi@webrtc.org Link to the patchset: https://codereview.webrtc.org/2777203003/#ps120001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/04 10:55:19, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... I'll include this change with the other one, as the other one got reverted. CL here: https://codereview.webrtc.org/2811963004/ |