Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2777063005:
MD Settings: Show password tooltip for full URL. (Closed)
|
Created:
3 years, 8 months ago by hcarmona Modified:
3 years, 8 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Show password tooltip for full URL.
Screenshot in the bug.
R=dschuyler@chromium.org
BUG=705574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2777063005
Cr-Commit-Position: refs/heads/master@{#460251}
Committed: https://chromium.googlesource.com/chromium/src/+/0484f901c29bf0ad0a007cf86b66677a4da57de9
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use title #Messages
Total messages: 21 (14 generated)
Description was changed from ========== MD Settings: Show password tooltip for full URL R=dschuyler@chromium.org BUG=705574 ========== to ========== MD Settings: Show password tooltip for full URL R=dschuyler@chromium.org BUG=705574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Description was changed from ========== MD Settings: Show password tooltip for full URL R=dschuyler@chromium.org BUG=705574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show password tooltip for full URL. Screenshot in the bug. R=dschuyler@chromium.org BUG=705574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2777063005/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2777063005/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:121: <paper-tooltip position="top">[[item.linkUrl]]</paper-tooltip> can we just set a title="" instead?
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
On 2017/03/28 13:02:08, Dan Beam (slow) wrote: > https://codereview.chromium.org/2777063005/diff/1/chrome/browser/resources/se... > File > chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html > (right): > > https://codereview.chromium.org/2777063005/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:121: > <paper-tooltip position="top">[[item.linkUrl]]</paper-tooltip> > can we just set a title="" instead? Thanks for the tip, switched to title. Updated screenshot in bug.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490742028116870,
"parent_rev": "5285d00f561827da882c8faaa7bda1d571c4fc60", "commit_rev":
"0484f901c29bf0ad0a007cf86b66677a4da57de9"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Show password tooltip for full URL. Screenshot in the bug. R=dschuyler@chromium.org BUG=705574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show password tooltip for full URL. Screenshot in the bug. R=dschuyler@chromium.org BUG=705574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2777063005 Cr-Commit-Position: refs/heads/master@{#460251} Committed: https://chromium.googlesource.com/chromium/src/+/0484f901c29bf0ad0a007cf86b66... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0484f901c29bf0ad0a007cf86b66...
Message was sent while issue was closed.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
Message was sent while issue was closed.
lgtm |
