Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 2776313002: Turn on DownloadAttribution feature by default (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on DownloadAttribution feature by default Prepare for 100% stable launch. Full launch approved. Also correct a comment in corresponding browsertest, since NOTIFICATION_RETARGETING has already been deprecated. BUG=639467 Review-Url: https://codereview.chromium.org/2776313002 Cr-Commit-Position: refs/heads/master@{#459954} Committed: https://chromium.googlesource.com/chromium/src/+/f0b120b107fa1429a89fa180561d098fbf0b77ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Jialiu Lin
Hi lpz@, Could you take a look at this small CL? Thanks!
3 years, 9 months ago (2017-03-27 22:03:19 UTC) #6
vakh (use Gerrit instead)
lgtm
3 years, 9 months ago (2017-03-27 22:17:05 UTC) #8
vakh (use Gerrit instead)
lgtm lgtm Hi :-)
3 years, 9 months ago (2017-03-27 22:17:15 UTC) #9
Jialiu Lin
Thank you vakh@!
3 years, 9 months ago (2017-03-27 22:34:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776313002/1
3 years, 9 months ago (2017-03-28 00:33:48 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f0b120b107fa1429a89fa180561d098fbf0b77ae
3 years, 9 months ago (2017-03-28 00:44:24 UTC) #18
lpz
3 years, 8 months ago (2017-03-28 14:23:16 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698