Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc

Issue 2775793003: Update XServerPixelBuffer to handle shmget() errors properly. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc
diff --git a/webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc b/webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc
index 2ecac6b8b0321c87da9645770942fd9f827507c9..522e688a8d0f91f3a3ac365dfa0a09774bee2fdc 100644
--- a/webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc
+++ b/webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.cc
@@ -154,7 +154,8 @@ void XServerPixelBuffer::InitShm(const XWindowAttributes& attributes) {
if (!using_shm) {
LOG(LS_WARNING) << "Not using shared memory. Performance may be degraded.";
- Release();
+ delete shm_segment_info_;
+ shm_segment_info_ = nullptr;
Hzj_jie 2017/03/25 00:30:30 It looks like in Release() function, there are bun
Sergey Ulanov 2017/03/27 19:23:06 Yes, good point. Fixed. Also update this code to s
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698