Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2774463003: Don't hardcode MediaType::ANY in FakeNetworkPipe. (Closed)
Patch Set: Update FakeCall::DeliverPacket, for consistency with Call::DeliverRtp. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/rtp_rtcp_observer.h ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index baf7161252935d5bf964c8c6e5453eb1a12993ce..87289f19d6b7ebb049caf01fafbbf27a7c34b06c 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -202,8 +202,10 @@ TEST_F(EndToEndTest, RendersSingleDelayedFrame) {
CreateCalls(Call::Config(&event_log_), Call::Config(&event_log_));
- test::DirectTransport sender_transport(sender_call_.get());
- test::DirectTransport receiver_transport(receiver_call_.get());
+ test::DirectTransport sender_transport(
+ sender_call_.get(), MediaType::VIDEO);
+ test::DirectTransport receiver_transport(
+ receiver_call_.get(), MediaType::VIDEO);
sender_transport.SetReceiver(receiver_call_->Receiver());
receiver_transport.SetReceiver(sender_call_->Receiver());
@@ -249,8 +251,10 @@ TEST_F(EndToEndTest, TransmitsFirstFrame) {
CreateCalls(Call::Config(&event_log_), Call::Config(&event_log_));
- test::DirectTransport sender_transport(sender_call_.get());
- test::DirectTransport receiver_transport(receiver_call_.get());
+ test::DirectTransport sender_transport(
+ sender_call_.get(), MediaType::VIDEO);
+ test::DirectTransport receiver_transport(
+ receiver_call_.get(), MediaType::VIDEO);
sender_transport.SetReceiver(receiver_call_->Receiver());
receiver_transport.SetReceiver(sender_call_->Receiver());
@@ -521,6 +525,7 @@ TEST_F(EndToEndTest, ReceivesNackAndRetransmitsAudio) {
test::PacketTransport* CreateReceiveTransport() override {
test::PacketTransport* receive_transport = new test::PacketTransport(
nullptr, this, test::PacketTransport::kReceiver,
+ MediaType::AUDIO,
FakeNetworkPipe::Config());
receive_transport_ = receive_transport;
return receive_transport;
@@ -782,7 +787,8 @@ class FlexfecRenderObserver : public test::EndToEndTest,
FakeNetworkPipe::Config config;
config.queue_delay_ms = kNetworkDelayMs;
return new test::PacketTransport(sender_call, this,
- test::PacketTransport::kSender, config);
+ test::PacketTransport::kSender,
+ MediaType::VIDEO, config);
}
void OnFrame(const VideoFrame& video_frame) override {
@@ -961,7 +967,8 @@ TEST_F(EndToEndTest, ReceivedUlpfecPacketsNotNacked) {
FakeNetworkPipe::Config config;
config.queue_delay_ms = kNetworkDelayMs;
return new test::PacketTransport(sender_call, this,
- test::PacketTransport::kSender, config);
+ test::PacketTransport::kSender,
+ MediaType::VIDEO, config);
}
// TODO(holmer): Investigate why we don't send FEC packets when the bitrate
@@ -1303,8 +1310,10 @@ TEST_F(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) {
CreateCalls(Call::Config(&event_log_), Call::Config(&event_log_));
- test::DirectTransport send_transport(sender_call_.get());
- test::DirectTransport receive_transport(receiver_call_.get());
+ test::DirectTransport send_transport(
+ sender_call_.get(), MediaType::VIDEO);
+ test::DirectTransport receive_transport(
+ receiver_call_.get(), MediaType::VIDEO);
PacketInputObserver input_observer(receiver_call_->Receiver());
send_transport.SetReceiver(&input_observer);
receive_transport.SetReceiver(sender_call_->Receiver());
@@ -1531,10 +1540,10 @@ class MultiStreamTest {
VideoReceiveStream::Config* receive_config) {
}
virtual test::DirectTransport* CreateSendTransport(Call* sender_call) {
- return new test::DirectTransport(sender_call);
+ return new test::DirectTransport(sender_call, MediaType::VIDEO);
}
virtual test::DirectTransport* CreateReceiveTransport(Call* receiver_call) {
- return new test::DirectTransport(receiver_call);
+ return new test::DirectTransport(receiver_call, MediaType::VIDEO);
}
};
@@ -1613,7 +1622,7 @@ TEST_F(EndToEndTest, AssignsTransportSequenceNumbers) {
RtpExtensionHeaderObserver(Call* sender_call,
const uint32_t& first_media_ssrc,
const std::map<uint32_t, uint32_t>& ssrc_map)
- : DirectTransport(sender_call),
+ : DirectTransport(sender_call, MediaType::VIDEO),
done_(false, false),
parser_(RtpHeaderParser::Create()),
first_media_ssrc_(first_media_ssrc),
@@ -1929,8 +1938,10 @@ TEST_F(EndToEndTest, ObserversEncodedFrames) {
CreateCalls(Call::Config(&event_log_), Call::Config(&event_log_));
- test::DirectTransport sender_transport(sender_call_.get());
- test::DirectTransport receiver_transport(receiver_call_.get());
+ test::DirectTransport sender_transport(
+ sender_call_.get(), MediaType::VIDEO);
+ test::DirectTransport receiver_transport(
+ receiver_call_.get(), MediaType::VIDEO);
sender_transport.SetReceiver(receiver_call_->Receiver());
receiver_transport.SetReceiver(sender_call_->Receiver());
@@ -2094,6 +2105,7 @@ TEST_F(EndToEndTest, RembWithSendSideBwe) {
test::PacketTransport* CreateReceiveTransport() override {
receive_transport_ = new test::PacketTransport(
nullptr, this, test::PacketTransport::kReceiver,
+ MediaType::VIDEO,
FakeNetworkPipe::Config());
return receive_transport_;
}
@@ -3057,7 +3069,8 @@ TEST_F(EndToEndTest, GetStats) {
FakeNetworkPipe::Config network_config;
network_config.loss_percent = 5;
return new test::PacketTransport(
- sender_call, this, test::PacketTransport::kSender, network_config);
+ sender_call, this, test::PacketTransport::kSender, MediaType::VIDEO,
+ network_config);
}
Call::Config GetSenderCallConfig() override {
@@ -3611,9 +3624,11 @@ void EndToEndTest::TestRtpStatePreservation(bool use_rtx,
test::PacketTransport send_transport(sender_call_.get(), &observer,
test::PacketTransport::kSender,
+ MediaType::VIDEO,
FakeNetworkPipe::Config());
test::PacketTransport receive_transport(nullptr, &observer,
test::PacketTransport::kReceiver,
+ MediaType::VIDEO,
FakeNetworkPipe::Config());
send_transport.SetReceiver(receiver_call_->Receiver());
receive_transport.SetReceiver(sender_call_->Receiver());
@@ -3906,9 +3921,11 @@ TEST_F(EndToEndTest, CallReportsRttForSender) {
FakeNetworkPipe::Config config;
config.queue_delay_ms = kSendDelayMs;
- test::DirectTransport sender_transport(config, sender_call_.get());
+ test::DirectTransport sender_transport(
+ config, sender_call_.get(), MediaType::VIDEO);
config.queue_delay_ms = kReceiveDelayMs;
- test::DirectTransport receiver_transport(config, receiver_call_.get());
+ test::DirectTransport receiver_transport(
+ config, receiver_call_.get(), MediaType::VIDEO);
sender_transport.SetReceiver(receiver_call_->Receiver());
receiver_transport.SetReceiver(sender_call_->Receiver());
@@ -3970,7 +3987,7 @@ void EndToEndTest::VerifyNewVideoReceiveStreamsRespectNetworkState(
CreateCalls(config, config);
receiver_call_->SignalChannelNetworkState(network_to_bring_up, kNetworkUp);
- test::DirectTransport sender_transport(sender_call_.get());
+ test::DirectTransport sender_transport(sender_call_.get(), MediaType::VIDEO);
sender_transport.SetReceiver(receiver_call_->Receiver());
CreateSendConfig(1, 0, 0, &sender_transport);
CreateMatchingReceiveConfigs(transport);
« no previous file with comments | « webrtc/test/rtp_rtcp_observer.h ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698