Conversational Speech tool, WavReaderAdaptor and unit test

webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h

Index: webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h
diff --git a/webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h b/webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h
index 54894934dbc5f4b5fd84d88afeff680a649810a8..530aabaa69a2f0b349df5590d3e30f84a6506965 100644
--- a/webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h
+++ b/webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h
@@ -16,6 +16,7 @@
 #include <cstddef>
 #include <string>
 
+#include "webrtc/common_audio/wav_file.h"
 #include "webrtc/typedefs.h"
 
 namespace webrtc {
@@ -33,6 +34,8 @@ class WavReaderAdaptor : public WavReaderInterface {
   int sample_rate() const override;
   size_t num_channels() const override;
   size_t num_samples() const override;
+ private:
+  WavReader wav_reader_;

[kwiberg-webrtc, 2017/03/28 17:52:45]

When you add this private member variable, you have to #include wav_file.h,
which is visible to anyone who #includes this file.

If you're open to moving code around a bit, I'd suggest moving this entire class
definition to the .cc file, and keeping just one thing in this header:

  std::unique_ptr<WavReaderInterface> CreateWavReaderAdaptor(const std::string&
filepath);

As an added bonus, everything in the .cc file (except for the definition of that
function) can then be in an anonymous namespace.

[AleBzk, 2017/03/29 08:56:45]

Done.

 };
 
 }  // namespace conversational_speech