Conversational Speech tool, WavReaderAdaptor and unit test

webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/audio_processing/test/conversational_speech/wavreader_adaptor.h"
 
+#include <cstddef>
+
+#include "webrtc/base/array_view.h"
 #include "webrtc/base/checks.h"
+#include "webrtc/common_audio/wav_file.h"
+#include "webrtc/typedefs.h"
 
 namespace webrtc {
 namespace test {
+namespace {
+
+using conversational_speech::WavReaderInterface;
+
+class WavReaderAdaptor : public WavReaderInterface {

[kwiberg-webrtc, 2017/03/29 09:08:28]

final? Like const, it's usually a good idea to use it whenever the compiler lets
you.

[AleBzk, 2017/03/29 09:34:43]

Done.

+ public:
+  explicit WavReaderAdaptor(const std::string& filepath)
+      : wav_reader_(filepath) {}
+  ~WavReaderAdaptor() override = default;
+
+  size_t ReadFloatSamples(rtc::ArrayView<float> samples) override {
+    return wav_reader_.ReadSamples(samples.size(), samples.begin());
+  }
+
+  size_t ReadInt16Samples(rtc::ArrayView<int16_t> samples) override {
+    return wav_reader_.ReadSamples(samples.size(), samples.begin());
+  }
+
+  int sample_rate() const override {
+    return wav_reader_.sample_rate();
+  }
+
+  size_t num_channels() const override {
+    return wav_reader_.num_channels();
+  }
+
+  size_t num_samples() const override {
+    return wav_reader_.num_samples();
+  }
+
+ private:
+  WavReader wav_reader_;
+};
+
+}  // namespace
+
 namespace conversational_speech {
 
-WavReaderAdaptor::WavReaderAdaptor(const std::string& filepath) {
-  // TODO(alessiob): implement.
-}
-
-WavReaderAdaptor::~WavReaderAdaptor() {}
-
-size_t WavReaderAdaptor::ReadFloatSamples(size_t num_samples, float* samples) {
-  // TODO(alessiob): implement.
-  FATAL();
-  return 0u;
-}
-
-size_t WavReaderAdaptor::ReadInt16Samples(
-    size_t num_samples, int16_t* samples) {
-  // TODO(alessiob): implement.
-  FATAL();
-  return 0u;
-}
-
-int WavReaderAdaptor::sample_rate() const {
-  // TODO(alessiob): implement.
-  FATAL();
-  return 0;
-}
-
-size_t WavReaderAdaptor::num_channels() const {
-  // TODO(alessiob): implement.
-  FATAL();
-  return 0u;
-}
-
-size_t WavReaderAdaptor::num_samples() const {
-  // TODO(alessiob): implement.
-  FATAL();
-  return 0u;
+std::unique_ptr<WavReaderInterface> CreateWavReaderAdaptor(
+    const std::string& filepath) {
+  return std::unique_ptr<WavReaderAdaptor>(new WavReaderAdaptor(filepath));
 }
 
 }  // namespace conversational_speech
 }  // namespace test
 }  // namespace webrtc