Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2774123002: Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video. (Closed)
Patch Set: Comment addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 7c6d7940f685cd9e11aa4f90227b93582ccf6ce0..aa2f6640c078fc2eb7b209783fa06cfd4ac0ddf4 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -1638,14 +1638,6 @@ bool WebRtcVoiceMediaChannel::SetSendParameters(
return false;
}
- if (params.max_bandwidth_bps >= 0) {
- // Note that max_bandwidth_bps intentionally takes priority over the
- // bitrate config for the codec.
- bitrate_config_.max_bitrate_bps =
- params.max_bandwidth_bps == 0 ? -1 : params.max_bandwidth_bps;
- }
- call_->SetBitrateConfig(bitrate_config_);
-
if (!ValidateRtpExtensions(params.extensions)) {
return false;
}
@@ -1917,6 +1909,7 @@ bool WebRtcVoiceMediaChannel::SetSendCodecs(
// parameters.
// TODO(solenberg): Refactor this logic once we create AudioEncoders here.
webrtc::AudioSendStream::Config::SendCodecSpec send_codec_spec;
+ webrtc::Call::Config::BitrateConfig bitrate_config;
{
send_codec_spec.nack_enabled = send_codec_spec_.nack_enabled;
@@ -1930,7 +1923,7 @@ bool WebRtcVoiceMediaChannel::SetSendCodecs(
send_codec_spec.transport_cc_enabled = HasTransportCc(*codec);
send_codec_spec.nack_enabled = HasNack(*codec);
- bitrate_config_ = GetBitrateConfigForCodec(*codec);
+ bitrate_config = GetBitrateConfigForCodec(*codec);
// For Opus as the send codec, we are to determine inband FEC, maximum
// playback rate, and opus internal dtx.
@@ -2007,8 +2000,9 @@ bool WebRtcVoiceMediaChannel::SetSendCodecs(
} else {
// If the codec isn't changing, set the start bitrate to -1 which means
// "unchanged" so that BWE isn't affected.
- bitrate_config_.start_bitrate_bps = -1;
+ bitrate_config.start_bitrate_bps = -1;
}
+ call_->SetBitrateConfig(bitrate_config);
// Check if the transport cc feedback or NACK status has changed on the
// preferred send codec, and in that case reconfigure all receive streams.
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698