Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2774123002: Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 7c6d7940f685cd9e11aa4f90227b93582ccf6ce0..2db7061364088b859faa2b10df0ccf6265c15420 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -1638,12 +1638,6 @@ bool WebRtcVoiceMediaChannel::SetSendParameters(
return false;
}
- if (params.max_bandwidth_bps >= 0) {
- // Note that max_bandwidth_bps intentionally takes priority over the
- // bitrate config for the codec.
- bitrate_config_.max_bitrate_bps =
- params.max_bandwidth_bps == 0 ? -1 : params.max_bandwidth_bps;
- }
call_->SetBitrateConfig(bitrate_config_);
minyue-webrtc 2017/03/27 09:22:06 I think there is no need to call this if we remove
stefan-webrtc 2017/03/27 10:10:27 Done.
if (!ValidateRtpExtensions(params.extensions)) {
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698