Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: webrtc/pc/rtpreceiver.h

Issue 2770233003: Implemented the GetSources() in native code. (Closed)
Patch Set: Merge and add the tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/rtpreceiver.h
diff --git a/webrtc/pc/rtpreceiver.h b/webrtc/pc/rtpreceiver.h
index 513f90c7ab3d9a00796868fe32a85bf5069e7d85..9bef83df4827477bb44001f1d091cf8847c3d8e4 100644
--- a/webrtc/pc/rtpreceiver.h
+++ b/webrtc/pc/rtpreceiver.h
@@ -30,6 +30,8 @@
namespace webrtc {
+class RtpContributingSource;
+
// Internal class used by PeerConnection.
class RtpReceiverInternal : public RtpReceiverInterface {
public:
@@ -37,6 +39,13 @@ class RtpReceiverInternal : public RtpReceiverInterface {
// This SSRC is used as an identifier for the receiver between the API layer
// and the WebRtcVideoEngine2, WebRtcVoiceEngine layer.
virtual uint32_t ssrc() const = 0;
+
+ // TODO(zhihuang): Remove the default implemenation once the subclasses
Taylor Brandstetter 2017/03/30 22:55:38 nit: Spelling of "implementation" Also, isn't the
Zhi Huang 2017/03/31 06:44:05 Done.
+ // implement this.
+ virtual std::vector<std::unique_ptr<RtpContributingSourceInterface>>
+ GetContributingSources() {
+ return std::vector<std::unique_ptr<RtpContributingSourceInterface>>();
+ }
};
class AudioRtpReceiver : public ObserverInterface,
@@ -88,6 +97,9 @@ class AudioRtpReceiver : public ObserverInterface,
// Should call SetChannel(nullptr) before |channel| is destroyed.
void SetChannel(cricket::VoiceChannel* channel);
+ std::vector<std::unique_ptr<RtpContributingSourceInterface>>
+ GetContributingSources() override;
+
private:
void Reconfigure();
void OnFirstPacketReceived(cricket::BaseChannel* channel);

Powered by Google App Engine
This is Rietveld 408576698