webrtc/voice_engine/channel_proxy.cc - Issue 2770233003: Implemented the GetSources() in native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel_proxy.cc

Issue 2770233003: Implemented the GetSources() in native code. (Closed)

Patch Set: Address the comments related to threading and the special ContributingSource that uses the SSRC. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/voice_engine/channel_proxy.cc

diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc

index de982977ca54c103a0d136911f1b4cfd1e83b0ce..d537032f3d373fcad423761defeab82aaac5d472 100644

--- a/webrtc/voice_engine/channel_proxy.cc

+++ b/webrtc/voice_engine/channel_proxy.cc

@@ -391,6 +391,12 @@ void ChannelProxy::RegisterLegacyReceiveCodecs() {

channel()->RegisterLegacyReceiveCodecs();

}

+const std::vector<RtpContributingSource>&

+ChannelProxy::GetContributingSources() {

+ RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());

+ return channel()->GetContributingSources();

Channel* ChannelProxy::channel() const {

RTC_DCHECK(channel_owner_.channel());

return channel_owner_.channel();