tools-webrtc/download_tools.py - Issue 2767383005: Add Windows, Mac, Android support to low bandwidth audio test - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1)

My Issues | Starred Open | Closed | All

Unified Diff: tools-webrtc/download_tools.py

Issue 2767383005: Add Windows, Mac, Android support to low bandwidth audio test (Closed)

Patch Set: Fix Android build errors Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | webrtc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools-webrtc/download_tools.py

diff --git a/tools-webrtc/download_tools.py b/tools-webrtc/download_tools.py

index dc64ebf8b80577b6facbe9031954d0c8d25ad3ef..123fd3a4a563583b08e30481f7c490145923a3f4 100755

--- a/tools-webrtc/download_tools.py

+++ b/tools-webrtc/download_tools.py

@@ -20,6 +20,8 @@ import sys

SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))

+# Needed to properly resolve PATH and executable extensions on Windows.

+USE_SHELL = sys.platform == 'win32'

def main(directories):

@@ -37,7 +39,7 @@ def main(directories):

path,

]

print 'Downloading precompiled tools...'

- subprocess.check_call(cmd)

+ subprocess.check_call(cmd, shell=USE_SHELL)

if __name__ == '__main__':

« no previous file with comments | « no previous file | webrtc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698