Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2765663002: Vp9: Enable denoiser by default. (Closed)
Patch Set: Change the unittest. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1953 matching lines...) Expand 10 before | Expand all | Expand 10 after
1964 cricket::FakeVideoCapturer capturer; 1964 cricket::FakeVideoCapturer capturer;
1965 EXPECT_EQ(cricket::CS_RUNNING, 1965 EXPECT_EQ(cricket::CS_RUNNING,
1966 capturer.Start(capturer.GetSupportedFormats()->front())); 1966 capturer.Start(capturer.GetSupportedFormats()->front()));
1967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, true, nullptr, &capturer)); 1967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, true, nullptr, &capturer));
1968 channel_->SetSend(true); 1968 channel_->SetSend(true);
1969 1969
1970 EXPECT_TRUE(capturer.CaptureFrame()); 1970 EXPECT_TRUE(capturer.CaptureFrame());
1971 1971
1972 webrtc::VideoCodecVP9 vp9_settings; 1972 webrtc::VideoCodecVP9 vp9_settings;
1973 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set."; 1973 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
1974 EXPECT_FALSE(vp9_settings.denoisingOn) 1974 EXPECT_TRUE(vp9_settings.denoisingOn)
1975 << "VP9 denoising should be off by default."; 1975 << "VP9 denoising should be on by default.";
1976 1976
1977 stream = SetDenoisingOption(last_ssrc_, &capturer, false); 1977 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
1978 1978
1979 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set."; 1979 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
1980 EXPECT_FALSE(vp9_settings.denoisingOn); 1980 EXPECT_FALSE(vp9_settings.denoisingOn);
1981 // Frame dropping always on for real time video. 1981 // Frame dropping always on for real time video.
1982 EXPECT_TRUE(vp9_settings.frameDroppingOn); 1982 EXPECT_TRUE(vp9_settings.frameDroppingOn);
1983 1983
1984 stream = SetDenoisingOption(last_ssrc_, &capturer, true); 1984 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
1985 1985
(...skipping 2368 matching lines...) Expand 10 before | Expand all | Expand 10 after
4354 } 4354 }
4355 4355
4356 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsForSimulcastScreenshare) { 4356 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsForSimulcastScreenshare) {
4357 webrtc::test::ScopedFieldTrials override_field_trials_( 4357 webrtc::test::ScopedFieldTrials override_field_trials_(
4358 "WebRTC-SimulcastScreenshare/Enabled/"); 4358 "WebRTC-SimulcastScreenshare/Enabled/");
4359 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true, 4359 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
4360 true); 4360 true);
4361 } 4361 }
4362 4362
4363 } // namespace cricket 4363 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698