third_party/WebKit/Source/web/WebRemoteFrameImpl.h - Issue 2764773003: Change WebFrameImplBase::initializeCoreFrame to take a Page&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

Issue 2764773003: Change WebFrameImplBase::initializeCoreFrame to take a Page& (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

index 692f7fbc4784b8ec2704f2933fda4448c0545963..52cc9ce8a959c9b64c878942e17d373d931eaf7e 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h

@@ -17,7 +17,6 @@

namespace blink {

-class FrameHost;

class FrameOwner;

class RemoteFrame;

enum class WebFrameLoadType;

@@ -109,7 +108,7 @@ class WEB_EXPORT WebRemoteFrameImpl final

WebFrameImplBase* toImplBase() { return this; }

// WebFrameImplBase methods:

- void initializeCoreFrame(FrameHost*,

+ void initializeCoreFrame(Page&,

FrameOwner*,

const AtomicString& name) override;

RemoteFrame* frame() const override { return m_frame.get(); }