third_party/WebKit/Source/web/WebFrameImplBase.h - Issue 2764773003: Change WebFrameImplBase::initializeCoreFrame to take a Page&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 2764773003: Change WebFrameImplBase::initializeCoreFrame to take a Page& (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameImplBase.h

diff --git a/third_party/WebKit/Source/web/WebFrameImplBase.h b/third_party/WebKit/Source/web/WebFrameImplBase.h

index 9b5367c5772e99afffb85eac4e3bf66b5ab266b2..8134801532a4b81a16d6ba6cc28012074556980d 100644

--- a/third_party/WebKit/Source/web/WebFrameImplBase.h

+++ b/third_party/WebKit/Source/web/WebFrameImplBase.h

@@ -12,8 +12,8 @@

namespace blink {

class Frame;

-class FrameHost;

class FrameOwner;

+class Page;

// WebFrameImplBase exists to avoid the diamond inheritance problem:

// - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame.

@@ -33,7 +33,7 @@ class WEB_EXPORT WebFrameImplBase

public:

virtual ~WebFrameImplBase();

- virtual void initializeCoreFrame(FrameHost*,

+ virtual void initializeCoreFrame(Page&,

FrameOwner*,

const AtomicString& name) = 0;

// TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be