Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: webrtc/media/base/videosourceinterface.h

Issue 2764133002: Revert of Add framerate to VideoSinkWants and ability to signal on overuse (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/videocapturer_unittest.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 11 #ifndef WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
12 #define WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 12 #define WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
13 13
14 #include "webrtc/media/base/videosinkinterface.h" 14 #include "webrtc/media/base/videosinkinterface.h"
15 #include "webrtc/base/optional.h" 15 #include "webrtc/base/optional.h"
16 16
17 namespace rtc { 17 namespace rtc {
18 18
19 // VideoSinkWants is used for notifying the source of properties a video frame 19 // VideoSinkWants is used for notifying the source of properties a video frame
20 // should have when it is delivered to a certain sink. 20 // should have when it is delivered to a certain sink.
21 struct VideoSinkWants { 21 struct VideoSinkWants {
22 // Tells the source whether the sink wants frames with rotation applied. 22 // Tells the source whether the sink wants frames with rotation applied.
23 // By default, any rotation must be applied by the sink. 23 // By default, any rotation must be applied by the sink.
24 bool rotation_applied = false; 24 bool rotation_applied = false;
25 25
26 // Tells the source that the sink only wants black frames. 26 // Tells the source that the sink only wants black frames.
27 bool black_frames = false; 27 bool black_frames = false;
28 28
29 // Tells the source the maximum number of pixels the sink wants. 29 // Tells the source the maximum number of pixels the sink wants.
30 int max_pixel_count = std::numeric_limits<int>::max(); 30 rtc::Optional<int> max_pixel_count;
31 // Tells the source the desired number of pixels the sinks wants. This will 31 // Tells the source the desired number of pixels the sinks wants. This will
32 // typically be used when stepping the resolution up again when conditions 32 // typically be used when stepping the resolution up again when conditions
33 // have improved after an earlier downgrade. The source should select the 33 // have improved after an earlier downgrade. The source should select the
34 // closest resolution to this pixel count, but if max_pixel_count is set, it 34 // closest resolution to this pixel count, but if max_pixel_count is set, it
35 // still sets the absolute upper bound. 35 // still sets the absolute upper bound.
36 rtc::Optional<int> target_pixel_count; 36 rtc::Optional<int> target_pixel_count;
37 // Tells the source the maximum framerate the sink wants.
38 int max_framerate_fps = std::numeric_limits<int>::max();
39 }; 37 };
40 38
41 template <typename VideoFrameT> 39 template <typename VideoFrameT>
42 class VideoSourceInterface { 40 class VideoSourceInterface {
43 public: 41 public:
44 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink, 42 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink,
45 const VideoSinkWants& wants) = 0; 43 const VideoSinkWants& wants) = 0;
46 // RemoveSink must guarantee that at the time the method returns, 44 // RemoveSink must guarantee that at the time the method returns,
47 // there is no current and no future calls to VideoSinkInterface::OnFrame. 45 // there is no current and no future calls to VideoSinkInterface::OnFrame.
48 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0; 46 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0;
49 47
50 protected: 48 protected:
51 virtual ~VideoSourceInterface() {} 49 virtual ~VideoSourceInterface() {}
52 }; 50 };
53 51
54 } // namespace rtc 52 } // namespace rtc
55 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 53 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/videocapturer_unittest.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698