Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h

Issue 2763323002: DCHECK that no RTPPayloadRegistry instance is used for both audio and video (Closed)
Patch Set: We ♥ locks! Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h b/webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h
index 668fe876f2e326b90b2ea118d7e99918ef68180f..767bd07f269a5372a5a73d577fe19273302caac3 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h
@@ -138,6 +138,13 @@ class RTPPayloadRegistry {
// Only warn once per payload type, if an RTX packet is received but
// no associated payload type found in |rtx_payload_type_map_|.
std::set<int> payload_types_with_suppressed_warnings_ GUARDED_BY(crit_sect_);
+
+ // As a first step in splitting this class up in separate cases for audio and
+ // video, DCHECK that no instance is used for both audio and video.
+#if RTC_DCHECK_IS_ON
+ bool used_for_audio_ GUARDED_BY(crit_sect_) = false;
+ bool used_for_video_ GUARDED_BY(crit_sect_) = false;
+#endif
};
} // namespace webrtc
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698