Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: webrtc/modules/video_coding/generic_encoder.cc

Issue 2763023002: Propagate input capture time in ViEEncoder::OnFrame. (Closed)
Patch Set: Undo change to FrameGenerators, only FrameGeneratorCapturer need to set timestamp. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/test/frame_generator_capturer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/generic_encoder.cc
diff --git a/webrtc/modules/video_coding/generic_encoder.cc b/webrtc/modules/video_coding/generic_encoder.cc
index bfa534f8fb67ad2e78c5f9ee688628bf5e4bd7c3..50731c050aeec4548af668ea974191c516d47674 100644
--- a/webrtc/modules/video_coding/generic_encoder.cc
+++ b/webrtc/modules/video_coding/generic_encoder.cc
@@ -126,7 +126,11 @@ int32_t VCMGenericEncoder::RequestFrame(
// TODO(nisse): Used only with internal source. Delete as soon as
// that feature is removed. The only implementation I've been able
- // to find ignores what's in the frame.
+ // to find ignores what's in the frame. With one exception: It seems
+ // a few test cases, e.g.,
+ // VideoSendStreamTest.VideoSendStreamStopSetEncoderRateToZero, set
+ // internal_source to true and use FakeEncoder. And the latter will
+ // happily encode this 1x1 frame and pass it on down the pipeline.
return encoder_->Encode(VideoFrame(I420Buffer::Create(1, 1),
kVideoRotation_0, 0),
NULL, &frame_types);
« no previous file with comments | « no previous file | webrtc/test/frame_generator_capturer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698