Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/WebRemoteFrameImpl.h" 5 #include "web/WebRemoteFrameImpl.h"
6 6
7 #include "bindings/core/v8/DOMWrapperWorld.h" 7 #include "bindings/core/v8/DOMWrapperWorld.h"
8 #include "bindings/core/v8/WindowProxy.h" 8 #include "bindings/core/v8/WindowProxy.h"
9 #include "core/dom/Fullscreen.h" 9 #include "core/dom/Fullscreen.h"
10 #include "core/dom/RemoteSecurityContext.h" 10 #include "core/dom/RemoteSecurityContext.h"
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 // Partially related with the above FIXME--the init() call may trigger JS 340 // Partially related with the above FIXME--the init() call may trigger JS
341 // dispatch. However, 341 // dispatch. However,
342 // if the parent is remote, it should never be detached synchronously... 342 // if the parent is remote, it should never be detached synchronously...
343 DCHECK(child->frame()); 343 DCHECK(child->frame());
344 return child; 344 return child;
345 } 345 }
346 346
347 void WebRemoteFrameImpl::initializeCoreFrame(Page& page, 347 void WebRemoteFrameImpl::initializeCoreFrame(Page& page,
348 FrameOwner* owner, 348 FrameOwner* owner,
349 const AtomicString& name) { 349 const AtomicString& name) {
350 setCoreFrame(RemoteFrame::create(m_frameClient.get(), &page, owner)); 350 setCoreFrame(RemoteFrame::create(m_frameClient.get(), page, owner));
351 frame()->createView(); 351 frame()->createView();
352 m_frame->tree().setName(name); 352 m_frame->tree().setName(name);
353 } 353 }
354 354
355 WebRemoteFrame* WebRemoteFrameImpl::createRemoteChild( 355 WebRemoteFrame* WebRemoteFrameImpl::createRemoteChild(
356 WebTreeScopeType scope, 356 WebTreeScopeType scope,
357 const WebString& name, 357 const WebString& name,
358 WebSandboxFlags sandboxFlags, 358 WebSandboxFlags sandboxFlags,
359 WebRemoteFrameClient* client, 359 WebRemoteFrameClient* client,
360 WebFrame* opener) { 360 WebFrame* opener) {
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 } 527 }
528 528
529 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, 529 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
530 WebRemoteFrameClient* client) 530 WebRemoteFrameClient* client)
531 : WebRemoteFrame(scope), 531 : WebRemoteFrame(scope),
532 m_frameClient(RemoteFrameClientImpl::create(this)), 532 m_frameClient(RemoteFrameClientImpl::create(this)),
533 m_client(client), 533 m_client(client),
534 m_selfKeepAlive(this) {} 534 m_selfKeepAlive(this) {}
535 535
536 } // namespace blink 536 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698