Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 settings.getMinimumLogicalFontSize()); 539 settings.getMinimumLogicalFontSize());
540 overlaySettings.setScriptEnabled(true); 540 overlaySettings.setScriptEnabled(true);
541 overlaySettings.setPluginsEnabled(false); 541 overlaySettings.setPluginsEnabled(false);
542 overlaySettings.setLoadsImagesAutomatically(true); 542 overlaySettings.setLoadsImagesAutomatically(true);
543 // FIXME: http://crbug.com/363843. Inspector should probably create its 543 // FIXME: http://crbug.com/363843. Inspector should probably create its
544 // own graphics layers and attach them to the tree rather than going 544 // own graphics layers and attach them to the tree rather than going
545 // through some non-composited paint function. 545 // through some non-composited paint function.
546 overlaySettings.setAcceleratedCompositingEnabled(false); 546 overlaySettings.setAcceleratedCompositingEnabled(false);
547 547
548 LocalFrame* frame = 548 LocalFrame* frame =
549 LocalFrame::create(&dummyLocalFrameClient, m_overlayPage, 0); 549 LocalFrame::create(&dummyLocalFrameClient, *m_overlayPage, 0);
550 frame->setView(FrameView::create(*frame)); 550 frame->setView(FrameView::create(*frame));
551 frame->init(); 551 frame->init();
552 FrameLoader& loader = frame->loader(); 552 FrameLoader& loader = frame->loader();
553 frame->view()->setCanHaveScrollbars(false); 553 frame->view()->setCanHaveScrollbars(false);
554 frame->view()->setTransparent(true); 554 frame->view()->setTransparent(true);
555 555
556 const WebData& overlayPageHTMLResource = 556 const WebData& overlayPageHTMLResource =
557 Platform::current()->loadResource("InspectorOverlayPage.html"); 557 Platform::current()->loadResource("InspectorOverlayPage.html");
558 RefPtr<SharedBuffer> data = SharedBuffer::create( 558 RefPtr<SharedBuffer> data = SharedBuffer::create(
559 overlayPageHTMLResource.data(), overlayPageHTMLResource.size()); 559 overlayPageHTMLResource.data(), overlayPageHTMLResource.size());
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 bool InspectorOverlay::shouldSearchForNode() { 803 bool InspectorOverlay::shouldSearchForNode() {
804 return m_inspectMode != InspectorDOMAgent::NotSearching; 804 return m_inspectMode != InspectorDOMAgent::NotSearching;
805 } 805 }
806 806
807 void InspectorOverlay::inspect(Node* node) { 807 void InspectorOverlay::inspect(Node* node) {
808 if (m_domAgent) 808 if (m_domAgent)
809 m_domAgent->inspect(node); 809 m_domAgent->inspect(node);
810 } 810 }
811 811
812 } // namespace blink 812 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698