Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/DOMImplementation.h" 7 #include "core/dom/DOMImplementation.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/RemoteFrame.h" 9 #include "core/frame/RemoteFrame.h"
10 #include "core/html/HTMLDivElement.h" 10 #include "core/html/HTMLDivElement.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 *DOMImplementation::create(document())->createHTMLDocument("test")); 63 *DOMImplementation::create(document())->createHTMLDocument("test"));
64 ElementVisibilityObserver* observer = 64 ElementVisibilityObserver* observer =
65 new ElementVisibilityObserver(element, nullptr); 65 new ElementVisibilityObserver(element, nullptr);
66 observer->start(); 66 observer->start();
67 observer->stop(); 67 observer->stop();
68 // It should not crash. 68 // It should not crash.
69 } 69 }
70 70
71 TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) { 71 TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) {
72 Persistent<RemoteFrame> remoteFrame = 72 Persistent<RemoteFrame> remoteFrame =
73 RemoteFrame::create(new EmptyRemoteFrameClient(), &page(), nullptr); 73 RemoteFrame::create(new EmptyRemoteFrameClient(), page(), nullptr);
74 localFrameClient()->setParent(remoteFrame); 74 localFrameClient()->setParent(remoteFrame);
75 75
76 Persistent<HTMLElement> element = HTMLDivElement::create(document()); 76 Persistent<HTMLElement> element = HTMLDivElement::create(document());
77 ElementVisibilityObserver* observer = 77 ElementVisibilityObserver* observer =
78 new ElementVisibilityObserver(element, WTF::bind([](bool) {})); 78 new ElementVisibilityObserver(element, WTF::bind([](bool) {}));
79 observer->start(); 79 observer->start();
80 observer->deliverObservationsForTesting(); 80 observer->deliverObservationsForTesting();
81 observer->stop(); 81 observer->stop();
82 // It should not crash. 82 // It should not crash.
83 } 83 }
84 84
85 } // anonymous namespace 85 } // anonymous namespace
86 86
87 } // blink namespace 87 } // blink namespace
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698