Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: webrtc/config_unittest.cc

Issue 2761143002: Support encrypted RTP extensions (RFC 6904) (Closed)
Patch Set: More updates + support for adding/changing encrypted extensions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/config_unittest.cc
diff --git a/webrtc/config_unittest.cc b/webrtc/config_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b9b310f924b3a3abb91b8fa4aad846fd72d22826
--- /dev/null
+++ b/webrtc/config_unittest.cc
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/config.h"
+
+#include <vector>
+
+#include "webrtc/base/gunit.h"
+
+using webrtc::RtpExtension;
+
+static const char kExtensionUri1[] = "extension-uri1";
+static const char kExtensionUri2[] = "extension-uri2";
+
+static const RtpExtension kExtension1(kExtensionUri1, 1);
+static const RtpExtension kExtension1Encrypted(kExtensionUri1, 10, true);
+static const RtpExtension kExtension2(kExtensionUri2, 2);
+
+class ConfigTest : public testing::Test {
+ protected:
+ static std::vector<RtpExtension> MakeVector(const RtpExtension& extension) {
Taylor Brandstetter 2017/04/01 00:28:59 nit: Would it be possible to use the vector constr
joachim 2017/04/17 10:46:09 Done.
+ std::vector<RtpExtension> vec;
+ vec.push_back(extension);
+ return vec;
+ }
+};
+
+TEST_F(ConfigTest, TestRtpExtension_FilterDuplicateNonEncrypted) {
Taylor Brandstetter 2017/04/01 00:28:59 nit: I'd change this to "TEST(RtpExtensionTest, Fi
joachim 2017/04/17 10:46:09 Done.
+ std::vector<RtpExtension> extensions;
+ std::vector<RtpExtension> filtered;
+
+ extensions.push_back(kExtension1);
+ extensions.push_back(kExtension1Encrypted);
+ filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+ EXPECT_EQ(1u, filtered.size());
+ EXPECT_EQ(MakeVector(kExtension1Encrypted), filtered);
+
+ extensions.clear();
+ extensions.push_back(kExtension1Encrypted);
+ extensions.push_back(kExtension1);
+ filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+ EXPECT_EQ(1u, filtered.size());
+ EXPECT_EQ(MakeVector(kExtension1Encrypted), filtered);
+
+ extensions.clear();
+ extensions.push_back(kExtension1);
+ extensions.push_back(kExtension2);
+ filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+ EXPECT_EQ(2u, filtered.size());
+ EXPECT_EQ(extensions, filtered);
+}

Powered by Google App Engine
This is Rietveld 408576698