Support encrypted RTP extensions (RFC 6904)

webrtc/config_unittest.cc

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/config.h"
+
+#include <vector>
+
+#include "webrtc/base/gunit.h"
+
+using webrtc::RtpExtension;
+
+static const char kExtensionUri1[] = "extension-uri1";
+static const char kExtensionUri2[] = "extension-uri2";
+
+static const RtpExtension kExtension1(kExtensionUri1, 1);
+static const RtpExtension kExtension1Encrypted(kExtensionUri1, 10, true);
+static const RtpExtension kExtension2(kExtensionUri2, 2);
+
+class ConfigTest : public testing::Test {
+ protected:
+  static std::vector<RtpExtension> MakeVector(const RtpExtension& extension) {

[Taylor Brandstetter, 2017/04/01 00:28:59]

nit: Would it be possible to use the vector constructor that takes an
initializer list, making this unnecessary?

[joachim, 2017/04/17 10:46:09]

Done.

+    std::vector<RtpExtension> vec;
+    vec.push_back(extension);
+    return vec;
+  }
+};
+
+TEST_F(ConfigTest, TestRtpExtension_FilterDuplicateNonEncrypted) {

[Taylor Brandstetter, 2017/04/01 00:28:59]

nit: I'd change this to "TEST(RtpExtensionTest, FilterDuplicateNonEncrypted)".

[joachim, 2017/04/17 10:46:09]

Done.

+  std::vector<RtpExtension> extensions;
+  std::vector<RtpExtension> filtered;
+
+  extensions.push_back(kExtension1);
+  extensions.push_back(kExtension1Encrypted);
+  filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+  EXPECT_EQ(1u, filtered.size());
+  EXPECT_EQ(MakeVector(kExtension1Encrypted), filtered);
+
+  extensions.clear();
+  extensions.push_back(kExtension1Encrypted);
+  extensions.push_back(kExtension1);
+  filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+  EXPECT_EQ(1u, filtered.size());
+  EXPECT_EQ(MakeVector(kExtension1Encrypted), filtered);
+
+  extensions.clear();
+  extensions.push_back(kExtension1);
+  extensions.push_back(kExtension2);
+  filtered = RtpExtension::FilterDuplicateNonEncrypted(extensions);
+  EXPECT_EQ(2u, filtered.size());
+  EXPECT_EQ(extensions, filtered);
+}