Support encrypted RTP extensions (RFC 6904)

webrtc/api/peerconnectioninterface.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 853 matching lines @@
     // loopback interfaces.
     int network_ignore_mask = rtc::kDefaultNetworkIgnoreMask;
 
     // Sets the maximum supported protocol version. The highest version
     // supported by both ends will be used for the connection, i.e. if one
     // party supports DTLS 1.0 and the other DTLS 1.2, DTLS 1.0 will be used.
     rtc::SSLProtocolVersion ssl_max_version = rtc::SSL_PROTOCOL_DTLS_12;
 
     // Sets crypto related options, e.g. enabled cipher suites.
     rtc::CryptoOptions crypto_options;
+
+    // If set to true, encrypted RTP header extensions as defined in RFC 6904
+    // will be negotiated. They will be only used if both peers support ihem.

[pthatcher1, 2017/03/21 07:07:06]

ihem => them

[joachim, 2017/03/23 00:04:32]

Done.

+    bool enable_rtp_header_encryption = false;

[pthatcher1, 2017/03/21 07:07:06]

I think enable_encrypted_rtp_header_extensions would be slightly better.

[Taylor Brandstetter, 2017/03/22 18:00:10]

Is there a reason this is added here, and not in RTCConfiguration? I think
that's what we prefer by default.

[joachim, 2017/03/23 00:04:32]

Done.

[joachim, 2017/03/23 00:04:32]

I assumed that it would more be a general option like "ssl_max_version" or
"crypto_options" which will not be different per PeerConnection.

   };
 
   virtual void SetOptions(const Options& options) = 0;
 
   virtual rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
       const PeerConnectionInterface::RTCConfiguration& configuration,
       std::unique_ptr<cricket::PortAllocator> allocator,
       std::unique_ptr<rtc::RTCCertificateGeneratorInterface> cert_generator,
       PeerConnectionObserver* observer) = 0;
 
@@ skipping 212 matching lines @@
     cricket::WebRtcVideoEncoderFactory* encoder_factory,
     cricket::WebRtcVideoDecoderFactory* decoder_factory) {
   return CreatePeerConnectionFactory(
       worker_and_network_thread, worker_and_network_thread, signaling_thread,
       default_adm, encoder_factory, decoder_factory);
 }
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_PEERCONNECTIONINTERFACE_H_