Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h

Issue 2758533002: Fix rtcp_sender to support sdes with 31 chunk (Closed)
Patch Set: +todo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 10 matching lines...) Expand all
21 namespace rtcp { 21 namespace rtcp {
22 class CommonHeader; 22 class CommonHeader;
23 // Source Description (SDES) (RFC 3550). 23 // Source Description (SDES) (RFC 3550).
24 class Sdes : public RtcpPacket { 24 class Sdes : public RtcpPacket {
25 public: 25 public:
26 struct Chunk { 26 struct Chunk {
27 uint32_t ssrc; 27 uint32_t ssrc;
28 std::string cname; 28 std::string cname;
29 }; 29 };
30 static constexpr uint8_t kPacketType = 202; 30 static constexpr uint8_t kPacketType = 202;
31 static constexpr size_t kMaxNumberOfChunks = 0x1f;
31 32
32 Sdes(); 33 Sdes();
33 ~Sdes() override; 34 ~Sdes() override;
34 35
35 // Parse assumes header is already parsed and validated. 36 // Parse assumes header is already parsed and validated.
36 bool Parse(const CommonHeader& packet); 37 bool Parse(const CommonHeader& packet);
37 38
38 bool AddCName(uint32_t ssrc, std::string cname); 39 bool AddCName(uint32_t ssrc, std::string cname);
39 40
40 const std::vector<Chunk>& chunks() const { return chunks_; } 41 const std::vector<Chunk>& chunks() const { return chunks_; }
41 42
42 size_t BlockLength() const override { return block_length_; } 43 size_t BlockLength() const override { return block_length_; }
43 44
44 protected: 45 protected:
45 bool Create(uint8_t* packet, 46 bool Create(uint8_t* packet,
46 size_t* index, 47 size_t* index,
47 size_t max_length, 48 size_t max_length,
48 RtcpPacket::PacketReadyCallback* callback) const override; 49 RtcpPacket::PacketReadyCallback* callback) const override;
49 50
50 private: 51 private:
51 static const size_t kMaxNumberOfChunks = 0x1f;
52
53 std::vector<Chunk> chunks_; 52 std::vector<Chunk> chunks_;
54 size_t block_length_; 53 size_t block_length_;
55 }; 54 };
56 } // namespace rtcp 55 } // namespace rtcp
57 } // namespace webrtc 56 } // namespace webrtc
58 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_SDES_H_ 57 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_SDES_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698