Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: webrtc/voice_engine/channel.h

Issue 2755273004: Add thread check to ModuleProcessThread::DeRegisterModule (Closed)
Patch Set: Remove TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VOICE_ENGINE_CHANNEL_H_ 11 #ifndef WEBRTC_VOICE_ENGINE_CHANNEL_H_
12 #define WEBRTC_VOICE_ENGINE_CHANNEL_H_ 12 #define WEBRTC_VOICE_ENGINE_CHANNEL_H_
13 13
14 #include <memory> 14 #include <memory>
15 15
16 #include "webrtc/api/audio/audio_mixer.h" 16 #include "webrtc/api/audio/audio_mixer.h"
17 #include "webrtc/api/call/audio_sink.h" 17 #include "webrtc/api/call/audio_sink.h"
18 #include "webrtc/base/criticalsection.h" 18 #include "webrtc/base/criticalsection.h"
19 #include "webrtc/base/optional.h" 19 #include "webrtc/base/optional.h"
20 #include "webrtc/base/thread_checker.h"
20 #include "webrtc/common_audio/resampler/include/push_resampler.h" 21 #include "webrtc/common_audio/resampler/include/push_resampler.h"
21 #include "webrtc/common_types.h" 22 #include "webrtc/common_types.h"
22 #include "webrtc/modules/audio_coding/acm2/codec_manager.h" 23 #include "webrtc/modules/audio_coding/acm2/codec_manager.h"
23 #include "webrtc/modules/audio_coding/acm2/rent_a_codec.h" 24 #include "webrtc/modules/audio_coding/acm2/rent_a_codec.h"
24 #include "webrtc/modules/audio_coding/include/audio_coding_module.h" 25 #include "webrtc/modules/audio_coding/include/audio_coding_module.h"
25 #include "webrtc/modules/audio_conference_mixer/include/audio_conference_mixer_d efines.h" 26 #include "webrtc/modules/audio_conference_mixer/include/audio_conference_mixer_d efines.h"
26 #include "webrtc/modules/audio_processing/rms_level.h" 27 #include "webrtc/modules/audio_processing/rms_level.h"
27 #include "webrtc/modules/rtp_rtcp/include/remote_ntp_time_estimator.h" 28 #include "webrtc/modules/rtp_rtcp/include/remote_ntp_time_estimator.h"
28 #include "webrtc/modules/rtp_rtcp/include/rtp_header_parser.h" 29 #include "webrtc/modules/rtp_rtcp/include/rtp_header_parser.h"
29 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h" 30 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 virtual ~Channel(); 144 virtual ~Channel();
144 static int32_t CreateChannel( 145 static int32_t CreateChannel(
145 Channel*& channel, 146 Channel*& channel,
146 int32_t channelId, 147 int32_t channelId,
147 uint32_t instanceId, 148 uint32_t instanceId,
148 const VoEBase::ChannelConfig& config); 149 const VoEBase::ChannelConfig& config);
149 Channel(int32_t channelId, 150 Channel(int32_t channelId,
150 uint32_t instanceId, 151 uint32_t instanceId,
151 const VoEBase::ChannelConfig& config); 152 const VoEBase::ChannelConfig& config);
152 int32_t Init(); 153 int32_t Init();
154 void Terminate();
153 int32_t SetEngineInformation(Statistics& engineStatistics, 155 int32_t SetEngineInformation(Statistics& engineStatistics,
154 OutputMixer& outputMixer, 156 OutputMixer& outputMixer,
155 ProcessThread& moduleProcessThread, 157 ProcessThread& moduleProcessThread,
156 AudioDeviceModule& audioDeviceModule, 158 AudioDeviceModule& audioDeviceModule,
157 VoiceEngineObserver* voiceEngineObserver, 159 VoiceEngineObserver* voiceEngineObserver,
158 rtc::CriticalSection* callbackCritSect); 160 rtc::CriticalSection* callbackCritSect);
159 int32_t UpdateLocalTimeStamp(); 161 int32_t UpdateLocalTimeStamp();
160 162
161 void SetSink(std::unique_ptr<AudioSinkInterface> sink); 163 void SetSink(std::unique_ptr<AudioSinkInterface> sink);
162 164
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 499
498 bool pacing_enabled_; 500 bool pacing_enabled_;
499 PacketRouter* packet_router_ = nullptr; 501 PacketRouter* packet_router_ = nullptr;
500 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_; 502 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_;
501 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_; 503 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_;
502 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_; 504 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_;
503 std::unique_ptr<RateLimiter> retransmission_rate_limiter_; 505 std::unique_ptr<RateLimiter> retransmission_rate_limiter_;
504 506
505 // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed. 507 // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed.
506 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_; 508 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
509
510 rtc::ThreadChecker construction_thread_;
507 }; 511 };
508 512
509 } // namespace voe 513 } // namespace voe
510 } // namespace webrtc 514 } // namespace webrtc
511 515
512 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_ 516 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698