Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: webrtc/voice_engine/transport_feedback_packet_loss_tracker.h

Issue 2754373002: TransportFeedbackPacketLossTracker to receive std::vector<PacketFeedback> in place of the entire fe… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/transport_feedback_packet_loss_tracker.h
diff --git a/webrtc/voice_engine/transport_feedback_packet_loss_tracker.h b/webrtc/voice_engine/transport_feedback_packet_loss_tracker.h
index b8fd0cc4bbd19572df212631ffe0a0c56497a420..b728f8fbfd60464f8636a649a228ce861eb697ff 100644
--- a/webrtc/voice_engine/transport_feedback_packet_loss_tracker.h
+++ b/webrtc/voice_engine/transport_feedback_packet_loss_tracker.h
@@ -22,6 +22,8 @@ namespace rtcp {
class TransportFeedback;
}
+struct PacketFeedback;
+
class TransportFeedbackPacketLossTracker final {
public:
// * We count up to |max_window_size_ms| from the sent
@@ -36,7 +38,8 @@ class TransportFeedbackPacketLossTracker final {
void OnPacketAdded(uint16_t seq_num, int64_t send_time_ms);
- void OnReceivedTransportFeedback(const rtcp::TransportFeedback& feedback);
+ void OnNewTransportFeedbacks(
stefan-webrtc 2017/03/20 18:14:44 How about OnPacketFeedback()?
elad.alon_webrtc.org 2017/03/20 18:21:51 OnPacketFeedbacks, plural, maybe? Wdyt?
stefan-webrtc 2017/03/20 18:36:21 Sounds good.
elad.alon_webrtc.org 2017/03/20 18:49:09 Done.
+ const std::vector<PacketFeedback>& packet_feedbacks);
// Returns the packet loss rate, if the window has enough packet statuses to
// reliably compute it. Otherwise, returns empty.

Powered by Google App Engine
This is Rietveld 408576698